appease rubocop

Author: davidsiaw

.rubocop.yml

@@ -1,6 +1,8 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
+  NewCops: enable
+
   TargetRubyVersion: 3.3
   Exclude:
     - 'db/migrate/*.rb'

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2021-12-31 12:20:36 UTC using RuboCop version 1.24.0.
+# on 2024-05-26 04:33:44 UTC using RuboCop version 1.64.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new

Gemfile

@@ -60,8 +60,8 @@ group :development, :test do
 end
 
 group :test do
-  gem 'falcon-capybara', git: 'https://github.com/davidsiaw/falcon-capybara', ref: 'options-hash'
   gem 'database_cleaner'
+  gem 'falcon-capybara', git: 'https://github.com/davidsiaw/falcon-capybara', ref: 'options-hash'
   gem 'rspec_junit_formatter'
   gem 'selenium-webdriver'
   gem 'shoulda-matchers'

config/initializers/sidekiq.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 Sidekiq.configure_server do |config|
-  config.redis = { url: ENV['REDIS_URL'] }
+  config.redis = { url: ENV.fetch('REDIS_URL', nil) }
 end

lib/generators/api/api_generator.rb

@@ -47,14 +47,14 @@ def pname_of(tokens)
   end
 
   def fields
-    @fields ||= member_list.map do |member|
+    @fields ||= member_list.to_h do |member|
       tokens = member.split(':')
       [tokens[0], {
         param_name: pname_of(tokens),
         param_type: ptype_of(tokens),
         full_type: tokens[1]
       }]
-    end.to_h
+    end
   end
 
   private
@@ -128,7 +128,7 @@ def mount_api
               "    #{mount_statement}",
               mount_end].map { |x| "#{x}\n" }
 
-    File.open(main_api_path, 'wb') { |file| file.write(result) }
+    File.binwrite(main_api_path, result)
   end
 
   def unmount_api
@@ -138,7 +138,7 @@ def unmount_api
               mount_list_sans_statement,
               mount_end].map { |x| "#{x}\n" }
 
-    File.open(main_api_path, 'wb') { |file| file.write(result) }
+    File.binwrite(main_api_path, result)
   end
 end
 # rubocop:enable Metrics/ClassLength

spec/rails_helper.rb

@@ -23,7 +23,7 @@
 # directory. Alternatively, in the individual `*_spec.rb` files, manually
 # require only the support files necessary.
 #
-Dir[Rails.root.join('spec', 'support', '**', '*.rb')].sort.each { |f| require f }
+Dir[Rails.root.join('spec', 'support', '**', '*.rb')].each { |f| require f }
 
 # Checks for pending migrations and applies them before tests are run.
 # If you are not using ActiveRecord, you can remove these lines.
@@ -37,7 +37,7 @@
   # Remember to include global test helpers here
   include ConcernHelper
 
-  config.fixture_paths = ["#{::Rails.root}/spec/fixtures"]
+  config.fixture_paths = ["#{Rails.root}/spec/fixtures"]
 
   DatabaseCleaner.allow_remote_database_url = true
   config.use_transactional_fixtures = false