Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved location pinning/reordering #29

Open
Uj947nXmRqV2nRaWshKtHzTvckUUpD opened this issue Dec 20, 2022 · 6 comments
Open

Saved location pinning/reordering #29

Uj947nXmRqV2nRaWshKtHzTvckUUpD opened this issue Dec 20, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@Uj947nXmRqV2nRaWshKtHzTvckUUpD

ability to pin / unpin favorite locations

@davidtakac
Copy link
Owner

davidtakac commented Dec 21, 2022

Hello. In this case, would pinned locations be displayed at the top of the list?

@Uj947nXmRqV2nRaWshKtHzTvckUUpD
Copy link
Author

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented Dec 21, 2022

yes this is how i see it in the current layout. an icon should also be shown to indicate when it is pinned

@Uj947nXmRqV2nRaWshKtHzTvckUUpD
Copy link
Author

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented Dec 21, 2022

maybe a nice idea would be to also allow reordering them and also clear other locations (by swiping it left). for the pinned ones the swipe to remove should be disabled, requiring to unpin to be able to remove. by swiping right you would pin/unpin a location

@davidtakac
Copy link
Owner

Clearing non-selected locations is possible since 3.2.0, you just have to long-click and a dialog pops up.

I understand the pin and reorder ideas now, thank you. Do you have a lot of saved locations and require a mechanism to organize them? I'm just trying to understand your use case.

@Uj947nXmRqV2nRaWshKtHzTvckUUpD
Copy link
Author

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented Dec 21, 2022

yes, i watch multiple locations. indeed I see now that i am able to delete locations on latest version by long press.
for now, just a pin to top should do it, without extra stuff i suppose.

later on:

  • i would add some dots on left that make the locations draggable to order them
  • also one nice idea would be to show weather for each location, but i suppose that implies more api calls. so maybe you could limit by making api calls only for favourites and show the temperature only for these.

I don't know how this api works, but it s nice that it doesn't require an api key like openweather does which enforced all apps and the developers to request users to create one

@davidtakac
Copy link
Owner

Maybe reordering could replace pinning altogether? It seems to be a more powerful mechanic. Pinning just floats the items to the top, but reordering allows you to do that yourself and whatever else you wish.

show weather for each location

I thought about that a while ago and it could be done. I could just fetch offline data for the location if it exists.

I don't know how this api works, but it s nice that it doesn't require an api key like openweather does which enforced all apps and the developers to request users to create one

It's a great API :) They don't require an API key, just a UserAgent header that identifies the developer, and that the developer respects their backend by distributing load properly.

@davidtakac davidtakac changed the title favorite location Saved location pinning/reordering Dec 22, 2022
@davidtakac davidtakac added the enhancement New feature or request label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants