From ec0fa09fd46ce42b0af9027cce0d1f617f2e515b Mon Sep 17 00:00:00 2001
From: Jonathan Budzenski <jon@elastic.co>
Date: Fri, 22 Mar 2024 15:22:00 -0500
Subject: [PATCH] fix lint error

---
 .../roles/complete_with_endpoint_roles.cy.ts  | 534 +++++++++---------
 1 file changed, 269 insertions(+), 265 deletions(-)

diff --git a/x-pack/plugins/security_solution/public/management/cypress/e2e/serverless/roles/complete_with_endpoint_roles.cy.ts b/x-pack/plugins/security_solution/public/management/cypress/e2e/serverless/roles/complete_with_endpoint_roles.cy.ts
index 613251560d590c..472443d5e13146 100644
--- a/x-pack/plugins/security_solution/public/management/cypress/e2e/serverless/roles/complete_with_endpoint_roles.cy.ts
+++ b/x-pack/plugins/security_solution/public/management/cypress/e2e/serverless/roles/complete_with_endpoint_roles.cy.ts
@@ -31,335 +31,296 @@ import {
 } from '../../../screens';
 
 // Failing: See https://github.com/elastic/kibana/issues/179274
-describe.skip('User Roles for Security Complete PLI with Endpoint Complete addon', {
-  tags: ['@serverless'],
-  env: {
-    ftrConfig: {
-      productTypes: [
-        { product_line: 'security', product_tier: 'complete' },
-        { product_line: 'endpoint', product_tier: 'complete' },
-      ],
+describe.skip(
+  'User Roles for Security Complete PLI with Endpoint Complete addon',
+  {
+    tags: ['@serverless'],
+    env: {
+      ftrConfig: {
+        productTypes: [
+          { product_line: 'security', product_tier: 'complete' },
+          { product_line: 'endpoint', product_tier: 'complete' },
+        ],
+      },
     },
   },
-}, () => {
-  const allPages = getEndpointManagementPageList();
-  const pageById = getEndpointManagementPageMap();
-  const consoleHelpPanelResponseActionsTestSubj = getConsoleHelpPanelResponseActionTestSubj();
+  () => {
+    const allPages = getEndpointManagementPageList();
+    const pageById = getEndpointManagementPageMap();
+    const consoleHelpPanelResponseActionsTestSubj = getConsoleHelpPanelResponseActionTestSubj();
 
-  let loadedEndpoints: CyIndexEndpointHosts;
+    let loadedEndpoints: CyIndexEndpointHosts;
 
-  before(() => {
-    indexEndpointHosts().then((response) => {
-      loadedEndpoints = response;
+    before(() => {
+      indexEndpointHosts().then((response) => {
+        loadedEndpoints = response;
+      });
     });
-  });
 
-  after(() => {
-    if (loadedEndpoints) {
-      loadedEndpoints.cleanup();
-    }
-  });
+    after(() => {
+      if (loadedEndpoints) {
+        loadedEndpoints.cleanup();
+      }
+    });
 
-  // roles `t1_analyst` and `t2_analyst` are very similar with exception of one page
-  [ROLE.t1_analyst, ROLE.t2_analyst].forEach((roleName) => {
-    describe(`for role: ${roleName}`, () => {
-      const deniedPages = allPages.filter((page) => page.id !== 'endpointList');
+    // roles `t1_analyst` and `t2_analyst` are very similar with exception of one page
+    [ROLE.t1_analyst, ROLE.t2_analyst].forEach((roleName) => {
+      describe(`for role: ${roleName}`, () => {
+        const deniedPages = allPages.filter((page) => page.id !== 'endpointList');
 
-      beforeEach(() => {
-        login(roleName);
-      });
+        beforeEach(() => {
+          login(roleName);
+        });
 
-      it('should have READ access to Endpoint list page', () => {
-        ensureEndpointListPageAuthzAccess('read', true);
-      });
+        it('should have READ access to Endpoint list page', () => {
+          ensureEndpointListPageAuthzAccess('read', true);
+        });
 
-      for (const { id, url, title } of deniedPages) {
-        // T2 analyst has Read view to Response Actions log
-        if (id === 'responseActionLog' && roleName === 't2_analyst') {
-          it(`should have access to: ${title}`, () => {
-            cy.visit(url);
-            getNoPrivilegesPage().should('not.exist');
-          });
-        } else {
-          it(`should NOT have access to: ${title}`, () => {
-            cy.visit(url);
-            getNoPrivilegesPage().should('exist');
-          });
+        for (const { id, url, title } of deniedPages) {
+          // T2 analyst has Read view to Response Actions log
+          if (id === 'responseActionLog' && roleName === 't2_analyst') {
+            it(`should have access to: ${title}`, () => {
+              cy.visit(url);
+              getNoPrivilegesPage().should('not.exist');
+            });
+          } else {
+            it(`should NOT have access to: ${title}`, () => {
+              cy.visit(url);
+              getNoPrivilegesPage().should('exist');
+            });
+          }
         }
-      }
 
-      it('should NOT have access to Fleet', () => {
-        visitFleetAgentList();
-        ensureFleetPermissionDeniedScreen();
-      });
+        it('should NOT have access to Fleet', () => {
+          visitFleetAgentList();
+          ensureFleetPermissionDeniedScreen();
+        });
 
-      it('should NOT have access to execute response actions', () => {
-        visitEndpointList();
-        openRowActionMenu().findByTestSubj('console').should('not.exist');
+        it('should NOT have access to execute response actions', () => {
+          visitEndpointList();
+          openRowActionMenu().findByTestSubj('console').should('not.exist');
+        });
       });
     });
-  });
-
-  describe('for role: t3_analyst', () => {
-    const artifactPagesFullAccess = [
-      pageById.trustedApps,
-      pageById.eventFilters,
-      pageById.hostIsolationExceptions,
-      pageById.blocklist,
-    ];
-
-    const grantedResponseActions = pick(
-      consoleHelpPanelResponseActionsTestSubj,
-      'isolate',
-      'release',
-      'processes',
-      'kill-process',
-      'suspend-process',
-      'get-file',
-      'upload'
-    );
-
-    const deniedResponseActions = pick(consoleHelpPanelResponseActionsTestSubj, 'execute');
-
-    beforeEach(() => {
-      login(ROLE.t3_analyst);
-    });
 
-    it('should have access to Endpoint list page', () => {
-      ensureEndpointListPageAuthzAccess('all', true);
-    });
+    describe('for role: t3_analyst', () => {
+      const artifactPagesFullAccess = [
+        pageById.trustedApps,
+        pageById.eventFilters,
+        pageById.hostIsolationExceptions,
+        pageById.blocklist,
+      ];
 
-    it('should have read access to Endpoint Policy Management', () => {
-      ensurePolicyListPageAuthzAccess('read', true);
-      ensurePolicyDetailsPageAuthzAccess(
-        loadedEndpoints.data.integrationPolicies[0].id,
-        'read',
-        true
+      const grantedResponseActions = pick(
+        consoleHelpPanelResponseActionsTestSubj,
+        'isolate',
+        'release',
+        'processes',
+        'kill-process',
+        'suspend-process',
+        'get-file',
+        'upload'
       );
-    });
 
-    for (const { title, id } of artifactPagesFullAccess) {
-      it(`should have CRUD access to: ${title}`, () => {
-        ensureArtifactPageAuthzAccess('all', id as EndpointArtifactPageId);
+      const deniedResponseActions = pick(consoleHelpPanelResponseActionsTestSubj, 'execute');
+
+      beforeEach(() => {
+        login(ROLE.t3_analyst);
       });
-    }
 
-    it('should NOT have access to Fleet', () => {
-      visitFleetAgentList();
-      ensureFleetPermissionDeniedScreen();
-    });
+      it('should have access to Endpoint list page', () => {
+        ensureEndpointListPageAuthzAccess('all', true);
+      });
 
-    describe('Response Actions access', () => {
-      beforeEach(() => {
-        visitEndpointList();
-        openConsoleFromEndpointList();
-        openConsoleHelpPanel();
+      it('should have read access to Endpoint Policy Management', () => {
+        ensurePolicyListPageAuthzAccess('read', true);
+        ensurePolicyDetailsPageAuthzAccess(
+          loadedEndpoints.data.integrationPolicies[0].id,
+          'read',
+          true
+        );
       });
 
-      for (const [action, testSubj] of Object.entries(grantedResponseActions)) {
-        it(`should have access to execute action: ${action}`, () => {
-          cy.getByTestSubj(testSubj).should('exist');
+      for (const { title, id } of artifactPagesFullAccess) {
+        it(`should have CRUD access to: ${title}`, () => {
+          ensureArtifactPageAuthzAccess('all', id as EndpointArtifactPageId);
         });
       }
 
-      for (const [action, testSubj] of Object.entries(deniedResponseActions)) {
-        it(`should NOT have access to execute: ${action}`, () => {
-          cy.getByTestSubj(testSubj).should('not.exist');
-        });
-      }
-    });
-  });
+      it('should NOT have access to Fleet', () => {
+        visitFleetAgentList();
+        ensureFleetPermissionDeniedScreen();
+      });
 
-  describe('for role: threat_intelligence_analyst', () => {
-    const deniedPages = allPages.filter(({ id }) => id !== 'blocklist' && id !== 'endpointList');
+      describe('Response Actions access', () => {
+        beforeEach(() => {
+          visitEndpointList();
+          openConsoleFromEndpointList();
+          openConsoleHelpPanel();
+        });
 
-    beforeEach(() => {
-      login(ROLE.threat_intelligence_analyst);
-    });
+        for (const [action, testSubj] of Object.entries(grantedResponseActions)) {
+          it(`should have access to execute action: ${action}`, () => {
+            cy.getByTestSubj(testSubj).should('exist');
+          });
+        }
 
-    it('should have access to Endpoint list page', () => {
-      ensureEndpointListPageAuthzAccess('read', true);
+        for (const [action, testSubj] of Object.entries(deniedResponseActions)) {
+          it(`should NOT have access to execute: ${action}`, () => {
+            cy.getByTestSubj(testSubj).should('not.exist');
+          });
+        }
+      });
     });
 
-    it(`should have CRUD access to: Blocklist`, () => {
-      cy.visit(pageById.blocklist.url);
-      getArtifactListEmptyStateAddButton(pageById.blocklist.id as EndpointArtifactPageId).should(
-        'exist'
-      );
-    });
+    describe('for role: threat_intelligence_analyst', () => {
+      const deniedPages = allPages.filter(({ id }) => id !== 'blocklist' && id !== 'endpointList');
 
-    for (const { url, title } of deniedPages) {
-      it(`should NOT have access to: ${title}`, () => {
-        cy.visit(url);
-        getNoPrivilegesPage().should('exist');
+      beforeEach(() => {
+        login(ROLE.threat_intelligence_analyst);
       });
-    }
-
-    it('should NOT have access to Fleet', () => {
-      visitFleetAgentList();
-      ensureFleetPermissionDeniedScreen();
-    });
 
-    it('should have access to Response Actions Log', () => {
-      cy.visit(pageById.responseActionLog);
-      getNoPrivilegesPage().should('not.exist');
-    });
+      it('should have access to Endpoint list page', () => {
+        ensureEndpointListPageAuthzAccess('read', true);
+      });
 
-    it('should NOT have access to execute response actions', () => {
-      visitEndpointList();
-      openRowActionMenu().findByTestSubj('console').should('not.exist');
-    });
-  });
+      it(`should have CRUD access to: Blocklist`, () => {
+        cy.visit(pageById.blocklist.url);
+        getArtifactListEmptyStateAddButton(pageById.blocklist.id as EndpointArtifactPageId).should(
+          'exist'
+        );
+      });
 
-  describe('for role: rule_author', () => {
-    const artifactPagesFullAccess = [
-      pageById.trustedApps,
-      pageById.eventFilters,
-      pageById.blocklist,
-    ];
+      for (const { url, title } of deniedPages) {
+        it(`should NOT have access to: ${title}`, () => {
+          cy.visit(url);
+          getNoPrivilegesPage().should('exist');
+        });
+      }
 
-    beforeEach(() => {
-      login(ROLE.rule_author);
-    });
+      it('should NOT have access to Fleet', () => {
+        visitFleetAgentList();
+        ensureFleetPermissionDeniedScreen();
+      });
 
-    for (const { id, title } of artifactPagesFullAccess) {
-      it(`should have CRUD access to: ${title}`, () => {
-        ensureArtifactPageAuthzAccess('all', id as EndpointArtifactPageId);
+      it('should have access to Response Actions Log', () => {
+        cy.visit(pageById.responseActionLog);
+        getNoPrivilegesPage().should('not.exist');
       });
-    }
 
-    it('should have access to Endpoint list page', () => {
-      ensureEndpointListPageAuthzAccess('all', true);
+      it('should NOT have access to execute response actions', () => {
+        visitEndpointList();
+        openRowActionMenu().findByTestSubj('console').should('not.exist');
+      });
     });
 
-    it('should have access to policy management', () => {
-      visitPolicyList();
-      getNoPrivilegesPage().should('not.exist');
-    });
+    describe('for role: rule_author', () => {
+      const artifactPagesFullAccess = [
+        pageById.trustedApps,
+        pageById.eventFilters,
+        pageById.blocklist,
+      ];
 
-    it(`should have Read access only to: Host Isolation Exceptions`, () => {
-      ensureArtifactPageAuthzAccess(
-        'read',
-        pageById.hostIsolationExceptions.id as EndpointArtifactPageId
-      );
-    });
+      beforeEach(() => {
+        login(ROLE.rule_author);
+      });
 
-    it('should NOT have access to Fleet', () => {
-      visitFleetAgentList();
-      ensureFleetPermissionDeniedScreen();
-    });
+      for (const { id, title } of artifactPagesFullAccess) {
+        it(`should have CRUD access to: ${title}`, () => {
+          ensureArtifactPageAuthzAccess('all', id as EndpointArtifactPageId);
+        });
+      }
 
-    it('should have access to Response Actions Log', () => {
-      cy.visit(pageById.responseActionLog);
-      getNoPrivilegesPage().should('not.exist');
-    });
+      it('should have access to Endpoint list page', () => {
+        ensureEndpointListPageAuthzAccess('all', true);
+      });
 
-    it('should NOT have access to execute response actions', () => {
-      visitEndpointList();
-      openRowActionMenu().findByTestSubj('console').should('not.exist');
-    });
-  });
-
-  describe('for role: soc_manager', () => {
-    const artifactPagesFullAccess = [
-      pageById.trustedApps,
-      pageById.eventFilters,
-      pageById.blocklist,
-      pageById.hostIsolationExceptions,
-    ];
-    const grantedAccessPages = [pageById.endpointList, pageById.policyList];
-
-    beforeEach(() => {
-      login(ROLE.soc_manager);
-    });
+      it('should have access to policy management', () => {
+        visitPolicyList();
+        getNoPrivilegesPage().should('not.exist');
+      });
+
+      it(`should have Read access only to: Host Isolation Exceptions`, () => {
+        ensureArtifactPageAuthzAccess(
+          'read',
+          pageById.hostIsolationExceptions.id as EndpointArtifactPageId
+        );
+      });
 
-    for (const { id, title } of artifactPagesFullAccess) {
-      it(`should have CRUD access to: ${title}`, () => {
-        ensureArtifactPageAuthzAccess('all', id as EndpointArtifactPageId);
+      it('should NOT have access to Fleet', () => {
+        visitFleetAgentList();
+        ensureFleetPermissionDeniedScreen();
       });
-    }
 
-    for (const { url, title } of grantedAccessPages) {
-      it(`should have access to: ${title}`, () => {
-        cy.visit(url);
+      it('should have access to Response Actions Log', () => {
+        cy.visit(pageById.responseActionLog);
         getNoPrivilegesPage().should('not.exist');
       });
-    }
 
-    it('should NOT have access to Fleet', () => {
-      visitFleetAgentList();
-      ensureFleetPermissionDeniedScreen();
+      it('should NOT have access to execute response actions', () => {
+        visitEndpointList();
+        openRowActionMenu().findByTestSubj('console').should('not.exist');
+      });
     });
 
-    describe('Response Actions access', () => {
+    describe('for role: soc_manager', () => {
+      const artifactPagesFullAccess = [
+        pageById.trustedApps,
+        pageById.eventFilters,
+        pageById.blocklist,
+        pageById.hostIsolationExceptions,
+      ];
+      const grantedAccessPages = [pageById.endpointList, pageById.policyList];
+
       beforeEach(() => {
-        visitEndpointList();
-        openConsoleFromEndpointList();
-        openConsoleHelpPanel();
+        login(ROLE.soc_manager);
       });
 
-      Object.entries(consoleHelpPanelResponseActionsTestSubj).forEach(([action, testSubj]) => {
-        it(`should have access to execute action: ${action}`, () => {
-          cy.getByTestSubj(testSubj).should('exist');
+      for (const { id, title } of artifactPagesFullAccess) {
+        it(`should have CRUD access to: ${title}`, () => {
+          ensureArtifactPageAuthzAccess('all', id as EndpointArtifactPageId);
         });
-      });
-    });
-  });
-
-  describe('for role: endpoint_operations_analyst', () => {
-    const artifactPagesFullAccess = [
-      pageById.trustedApps,
-      pageById.eventFilters,
-      pageById.blocklist,
-      pageById.hostIsolationExceptions,
-    ];
-
-    const grantedAccessPages = [pageById.endpointList, pageById.policyList];
+      }
 
-    beforeEach(() => {
-      login(ROLE.endpoint_operations_analyst);
-    });
+      for (const { url, title } of grantedAccessPages) {
+        it(`should have access to: ${title}`, () => {
+          cy.visit(url);
+          getNoPrivilegesPage().should('not.exist');
+        });
+      }
 
-    for (const { id, title } of artifactPagesFullAccess) {
-      it(`should have CRUD access to: ${title}`, () => {
-        ensureArtifactPageAuthzAccess('all', id as EndpointArtifactPageId);
+      it('should NOT have access to Fleet', () => {
+        visitFleetAgentList();
+        ensureFleetPermissionDeniedScreen();
       });
-    }
 
-    for (const { url, title } of grantedAccessPages) {
-      it(`should have access to: ${title}`, () => {
-        cy.visit(url);
-        getNoPrivilegesPage().should('not.exist');
-      });
-    }
+      describe('Response Actions access', () => {
+        beforeEach(() => {
+          visitEndpointList();
+          openConsoleFromEndpointList();
+          openConsoleHelpPanel();
+        });
 
-    Object.entries(consoleHelpPanelResponseActionsTestSubj).forEach(([action, testSubj]) => {
-      it(`should have access to response action: ${action}`, () => {
-        visitEndpointList();
-        openConsoleFromEndpointList();
-        openConsoleHelpPanel();
-        cy.getByTestSubj(testSubj).should('exist');
+        Object.entries(consoleHelpPanelResponseActionsTestSubj).forEach(([action, testSubj]) => {
+          it(`should have access to execute action: ${action}`, () => {
+            cy.getByTestSubj(testSubj).should('exist');
+          });
+        });
       });
     });
 
-    it('should have access to Fleet', () => {
-      visitFleetAgentList();
-      getFleetAgentListTable().should('exist');
-    });
-  });
-
-  [ROLE.platform_engineer, ROLE.endpoint_policy_manager].forEach((roleName) => {
-    describe(`for role: ${roleName}`, () => {
+    describe('for role: endpoint_operations_analyst', () => {
       const artifactPagesFullAccess = [
         pageById.trustedApps,
         pageById.eventFilters,
         pageById.blocklist,
         pageById.hostIsolationExceptions,
       ];
+
       const grantedAccessPages = [pageById.endpointList, pageById.policyList];
 
       beforeEach(() => {
-        login(roleName);
+        login(ROLE.endpoint_operations_analyst);
       });
 
       for (const { id, title } of artifactPagesFullAccess) {
@@ -375,25 +336,68 @@ describe.skip('User Roles for Security Complete PLI with Endpoint Complete addon
         });
       }
 
+      Object.entries(consoleHelpPanelResponseActionsTestSubj).forEach(([action, testSubj]) => {
+        it(`should have access to response action: ${action}`, () => {
+          visitEndpointList();
+          openConsoleFromEndpointList();
+          openConsoleHelpPanel();
+          cy.getByTestSubj(testSubj).should('exist');
+        });
+      });
+
       it('should have access to Fleet', () => {
         visitFleetAgentList();
         getFleetAgentListTable().should('exist');
       });
+    });
 
-      it('should have access to Response Actions Log', () => {
-        cy.visit(pageById.responseActionLog);
+    [ROLE.platform_engineer, ROLE.endpoint_policy_manager].forEach((roleName) => {
+      describe(`for role: ${roleName}`, () => {
+        const artifactPagesFullAccess = [
+          pageById.trustedApps,
+          pageById.eventFilters,
+          pageById.blocklist,
+          pageById.hostIsolationExceptions,
+        ];
+        const grantedAccessPages = [pageById.endpointList, pageById.policyList];
+
+        beforeEach(() => {
+          login(roleName);
+        });
 
-        if (roleName === 'endpoint_policy_manager') {
-          getNoPrivilegesPage().should('exist');
-        } else {
-          getNoPrivilegesPage().should('not.exist');
+        for (const { id, title } of artifactPagesFullAccess) {
+          it(`should have CRUD access to: ${title}`, () => {
+            ensureArtifactPageAuthzAccess('all', id as EndpointArtifactPageId);
+          });
         }
-      });
 
-      it('should NOT have access to execute response actions', () => {
-        visitEndpointList();
-        openRowActionMenu().findByTestSubj('console').should('not.exist');
+        for (const { url, title } of grantedAccessPages) {
+          it(`should have access to: ${title}`, () => {
+            cy.visit(url);
+            getNoPrivilegesPage().should('not.exist');
+          });
+        }
+
+        it('should have access to Fleet', () => {
+          visitFleetAgentList();
+          getFleetAgentListTable().should('exist');
+        });
+
+        it('should have access to Response Actions Log', () => {
+          cy.visit(pageById.responseActionLog);
+
+          if (roleName === 'endpoint_policy_manager') {
+            getNoPrivilegesPage().should('exist');
+          } else {
+            getNoPrivilegesPage().should('not.exist');
+          }
+        });
+
+        it('should NOT have access to execute response actions', () => {
+          visitEndpointList();
+          openRowActionMenu().findByTestSubj('console').should('not.exist');
+        });
       });
     });
-  });
-});
+  }
+);