Skip to content

Latest commit

 

History

History
57 lines (39 loc) · 1.66 KB

CONTRIBUTING.md

File metadata and controls

57 lines (39 loc) · 1.66 KB
Raw

Contributing to re-frame-http-fx

Thank you for taking the time to contribute!

Support questions

The Github issues are for bug reports and feature requests only. Support requests and usage questions should go to the re-frame Clojure Slack channel or the ClojureScript mailing list.

Pull requests

Create pull requests to the master branch.

Running tests

Via Browser/HTML

To auto compile the tests via shadow-cljs just:

lein watch

but you'll need to manually open test/test.html in a browser. And you'll also need to manually reload this page after each auto compile.

Via Karma

To run the tests, you must have recent versions of node, npm, Leiningen, and a C++ compiler toolchain installed. If you're on Linux or Mac OS X then you will be fine, if you're on Windows then you need to install Visual Studio Community Edition, and the C++ compiler dependencies.

lein ci # to build and run re-frame-http-fx tests
# or 
lein watch
karma start     # to run the tests with an auto watcher

Pull requests for bugs

If possible provide:

  • Code that fixes the bug
  • Failing tests which pass with the new changes
  • Improvements to documentation to make it less likely that others will run into issues (if relevant).
  • Add the change to the Unreleased section of CHANGES.md

Pull requests for features

If possible provide:

  • Code that implements the new feature
  • Tests to cover the new feature including all of the code paths
  • Docstrings for functions
  • Documentation examples
  • Add the change to the Unreleased section of CHANGES.md