From c2881434062dc7262cb18d1485d948ef36bfbd56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20F=C3=B6rster?= Date: Wed, 5 Feb 2025 17:56:35 +0100 Subject: [PATCH 1/2] [METASVC-152] Add detailed error message to WEMI filling proc --- .../entity/DigitalObjectServiceImpl.java | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/metasvc-server/business/src/main/java/io/github/dbmdz/metadata/server/business/impl/service/identifiable/entity/DigitalObjectServiceImpl.java b/metasvc-server/business/src/main/java/io/github/dbmdz/metadata/server/business/impl/service/identifiable/entity/DigitalObjectServiceImpl.java index 267194e28..20a63a67b 100644 --- a/metasvc-server/business/src/main/java/io/github/dbmdz/metadata/server/business/impl/service/identifiable/entity/DigitalObjectServiceImpl.java +++ b/metasvc-server/business/src/main/java/io/github/dbmdz/metadata/server/business/impl/service/identifiable/entity/DigitalObjectServiceImpl.java @@ -373,7 +373,23 @@ private void expandByWemiObjects(DigitalObject digitalObject) throws ServiceExce manifestationsWithWorks.parallelStream() .filter(m -> Objects.equals(m.getUuid(), item.getManifestation().getUuid())) .findFirst() - .get(); // must be there otherwise the SQL in getAllManifestationAndWorkUuids is wrong + // must be there otherwise the SQL in getAllManifestationAndWorkUuids is wrong + .orElseThrow( + () -> + new ServiceException( + """ + The item's manifestation could not be found although there must be one! + Item: %s; + Manifestation acc. to item: %s; + DigitalObject: %s + """ + .formatted( + item.getUuid().toString(), + Optional.ofNullable(item.getManifestation()) + .map(Manifestation::getUuid) + .map(UUID::toString) + .orElse(""), + digitalObject.getUuid().toString()))); item.setManifestation(manifestation); setNewestLastModified.accept(digitalObject, manifestation); From 6598016e1e3a042144b9801c25b2855e35e2fc46 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20F=C3=B6rster?= Date: Thu, 6 Feb 2025 12:09:33 +0100 Subject: [PATCH 2/2] Add changelog entry --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c2bf15d74..956abd009 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ## Unreleased +### Added + +- More detailed error message to WEMI filling procedure + ## [9.5.1](https://github.com/dbmdz/metadata-service/releases/tag/9.5.1) - 2025-01-22 ### Fixed