Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Test for date_spine should use a minimal date range #208

Open
3 tasks
dbeatty10 opened this issue May 14, 2024 · 0 comments · May be fixed by #211
Open
3 tasks

[Feature] Test for date_spine should use a minimal date range #208

dbeatty10 opened this issue May 14, 2024 · 0 comments · May be fixed by #211
Labels
enhancement New feature or request

Comments

@dbeatty10
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-adapters

Short description

The date range within fixture_date_spine.py is larger than needed.

Context

This doesn't affect the correctness of the test, but it does affect it's readability.

The test would be more readable with a minimal date range.

History: this test was migrated effectively as-is from dbt-utils to dbt-core to dbt-adapters. But now we'll probably want to clean it up a bit.

Acceptance criteria

Tasks

Testing

See acceptance criteria above.

Security

No security concerns.

Docs

No doc updates needed.

Consequences

This change impacts any adapter that imports this test. But it doesn't change the essence of the test and will effectively be a no-op.

@dbeatty10 dbeatty10 added the enhancement New feature or request label May 14, 2024
@dbeatty10 dbeatty10 linked a pull request May 14, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant