Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate block tag iteration #205

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Oct 15, 2024

resolves dbt-labs/dbt-core#9037

Description

The process of finding and iterating through jinja blocks could be quite slow. These changes accelerate the process by caching useful information about what searches have already been performed.

Many thanks to @fredriv for pointing out that this was still a problem and pushing for a fix.

Checklist

@peterallenwebb peterallenwebb requested a review from a team as a code owner October 15, 2024 21:48
@cla-bot cla-bot bot added the cla:yes label Oct 15, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.48%. Comparing base (ed11c6c) to head (6b18e61).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   68.33%   68.48%   +0.14%     
==========================================
  Files          52       52              
  Lines        3373     3389      +16     
==========================================
+ Hits         2305     2321      +16     
  Misses       1068     1068              
Flag Coverage Δ
unit 68.48% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 1bad6b7 Oct 15, 2024
16 checks passed
@peterallenwebb peterallenwebb deleted the paw/top-level-blocks-acceleration branch October 15, 2024 22:24
@emmyoop emmyoop mentioned this pull request Nov 5, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3361] Improve Docs Parsing Performance
3 participants