Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommended config links to outdated schema files #133

Open
gofford opened this issue Apr 12, 2024 · 1 comment
Open

recommended config links to outdated schema files #133

gofford opened this issue Apr 12, 2024 · 1 comment

Comments

@gofford
Copy link

gofford commented Apr 12, 2024

Using the jsonschema config from the README I noticed that some valid yaml config was being flagged as an error. Looking into it it seems that the config in the README is linking to outdated schema files.

The stated config is equivalent to sourcing https://github.com/dbt-labs/dbt-jsonschema/blob/main/schemas/dbt_project.json which hasn't been updated in 4 months. In contrast the versioned schema files (https://github.com/dbt-labs/dbt-jsonschema/tree/main/schemas/latest) were updated 4 days ago -- these changes aren't being reflected, hence my error.

If I update the yaml.schemas config to use the latest files my "error" goes away.

Two ways of solving this:

I'm happy to PR this - which one do you prefer?

@dave-connors-3
Copy link
Contributor

@gofford i think the first option sounds right to me! the schemas currently in noted in the README are mostly there for backwards compatibility, and won't get updates, so we should point folks to the latest ones. Thanks for the callout!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants