Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JSReporter for Jasmine 2 #1075

Closed
gordonwoodhull opened this issue Dec 23, 2015 · 0 comments
Closed

Upgrade JSReporter for Jasmine 2 #1075

gordonwoodhull opened this issue Dec 23, 2015 · 0 comments
Assignees
Milestone

Comments

@gordonwoodhull
Copy link
Contributor

Want to detail some consequences of the Jasmine 2 and jasmine-jsreporter upgrade.

Most of this comes from axemclion/grunt-saucelabs#109

We were getting saucelabs timeouts and I thought it was a lack of resources because it always seemed to happen on the second simultaneous build. I still don't know why it wasn't always failing, but looking into the VM logs on the saucelabs machines, it was complaining that window.jasmine.getJSReport was undefined. That doesn't sound good.

So first in 7f60197, I moved jasmine-jsreporter.js to web/js, instead of including it from node_modules as implemented in 43ba74c. Good idea anyway, but nope.

Poking around a little more, I found the issue above. So we need to add jsreporter to the jasmine environment manually in fa68f16. Okay.

Still failing. Need to trim the results to under 64k so that saucelabs can read them, pulled some code from the above issue to do that (and removed the jquery dependency), in ebaf8c9

Now perhaps we'll get consistent results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant