From 56cab029f1475607698f056973ed9d41f6967691 Mon Sep 17 00:00:00 2001 From: Diego <=> Date: Wed, 11 Dec 2019 11:41:26 -0300 Subject: [PATCH] Refactored naming convention --- README.md | 4 ++-- src/Extentions/DatabaseManager.php | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index b434330..b73df7c 100644 --- a/README.md +++ b/README.md @@ -11,8 +11,8 @@ #### Load secrets in AWS Secret Manager as key/value pairs -Naming convention: `<appname>/<env>/<conn_name> ` -**Ex: Blog/stage/mysql** +Naming convention: `<env>/<appname>/<conn_name> ` +**Ex: stage/Blog/mysql** #### Database configuration diff --git a/src/Extentions/DatabaseManager.php b/src/Extentions/DatabaseManager.php index cf27263..caf708b 100644 --- a/src/Extentions/DatabaseManager.php +++ b/src/Extentions/DatabaseManager.php @@ -17,7 +17,7 @@ protected function configuration($name) $dbconf = Config::get("database.connections." . $name); //if db driver is secret we get it from rest api / cache - if ($dbconf['driver'] == 'secret') { + if ($dbconf['driver'] == 'secret-db') { $config = $this->getSecret($name); if (is_null($config)) { //check if config is in cache @@ -61,7 +61,7 @@ public function getSecret($secret) 'region' => env('AWS_REGION'), ]); - $secretName = config('app.name') . '/' .config('app.env') . '/' . $secret; + $secretName = config('app.env') . '/'.config('app.name') . '/' . $secret; try { $result = $client->getSecretValue([