Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with ZNC 1.6 #12

Open
ticklemynausea opened this issue Feb 16, 2015 · 2 comments
Open

Compatibility with ZNC 1.6 #12

ticklemynausea opened this issue Feb 16, 2015 · 2 comments

Comments

@ticklemynausea
Copy link

znc-buildmod fails with the message:

Building "fish.so" for ZNC 1.6.0... fish.cpp: In member function ‘virtual CModule::EModRet CFishMod::OnUserMsg(CString&, CString&)’:
fish.cpp:332:62: error: invalid initialization of reference of type ‘std::vector<CClient*>&’ from expression of type ‘const std::vector<CClient*>’
fish.cpp: In member function ‘virtual CModule::EModRet CFishMod::OnUserAction(CString&, CString&)’:
fish.cpp:365:62: error: invalid initialization of reference of type ‘std::vector<CClient*>&’ from expression of type ‘const std::vector<CClient*>’
fish.cpp: In member function ‘virtual CModule::EModRet CFishMod::OnUserNotice(CString&, CString&)’:
fish.cpp:398:62: error: invalid initialization of reference of type ‘std::vector<CClient*>&’ from expression of type ‘const std::vector<CClient*>’
[ !! ] Error while building "fish.so"

Are there any plans for a new version?

@ticklemynausea
Copy link
Author

https://github.com/dctrwatson/znc-fish/pull/10/commits

this pull request seems to fix the issues

@philicious
Copy link

I didnt diff this repos fish.cpp nor the PR, but I can report that http://pastebin.com/K8zvJ89v (which is linked on http://wiki.znc.in/Fish as "For 1.4 and newer try this one"), is working fine with znc 1.6.3

just leaving this message for other people coming by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants