9월 15일 금요일 알고리즘 코드리뷰

[minseo9974]

Recursion

[minseo9974]

    public static long factorial(int number) {
        if (number < 0) {
            throw new IllegalArgumentException("not negative");
        }
        switch (number) {
            case 0:
                return 1;
            default:
                return number * factorial(number - 1);
        }
    }

    public static long fibonacci(int number) {
        if (number < 0) {
            throw new IllegalArgumentException("not negative");
        }
        switch (number) {
            case 0:
                return 0;
            case 1:
                return 1;
            default:
                return number + fibonacci(number - 1);
        }
    }

[dduneon]

return number + fibonacci(number - 1);
->
return fibonacci(number - 1) + fibonacci(number - 2);

[kys1651]

return number + fibonacci(number - 1);

[minseo9974]

피드백 감사합니다

[unggu0704]

  public static long factorial(int number) {
        switch (number) {
            case 1:
                return 1;
            default:
                return number * factorial(number - 1);
        }
    }

    public static long fibonacci(int number) {
        switch (number) {
            case 1:
                return 1;
            case 2:
                return 1;
            default:
                return fibonacci(number - 1) + fibonacci(number - 2);
        }
    }

[kys1651]

0일 때 처리하면 좋을 것 같아요

[unggu0704]

    public static long factorial(int number) {
        if (number < 0) 
            throw new IllegalArgumentException("음수 값이 입력 되었습니다.");
        switch (number) {
            case 0:
                return 1;
            default:
                return number * factorial(number - 1);
        }
    }

    public static long fibonacci(int number) {
        if (number < 0) 
            throw new IllegalArgumentException("음수 값이 입력 되었습니다.");
        switch (number) {
            case 0:
                return 0;
            case 1:
            case 2:
                return 1;
            default:
                return fibonacci(number - 1) + fibonacci(number - 2);
        }
    }

[dduneon]

    public static long factorial(int number) {
        if (number < 0)
            throw new IllegalArgumentException("Input Negative Number Error");

        switch (number) {
            case 0:
                return 1;
            default:
                return number * factorial(number - 1);
        }
    }

    public static long fibonacci(int number) {
        switch (number) {
            case 0:
                return 0;
            case 1:
            case 2:
                return 1;
            default:
                return fibonacci(number - 1) + fibonacci(number - 2);
        }
    }

[kys1651]

아주 좋은 코드군요

[kys1651]

public static long factorial(int number) {
        if(number < 0){
            throw new IllegalArgumentException("Negative Num");
        }
        
        switch (number) {
            case 0:
                return 1;
            default:
                return number * factorial(number - 1);
        }
    }

    public static long fibonacci(int number) {
        if(number < 0)
            throw new IllegalArgumentException("Negative Num");
        switch (number) {
            case 0:
                return 0;
            case 1:
                return 1;
            default:
                return fibonacci(number - 1) + fibonacci(number - 2);
        }
    }

[dduneon]

case 2: 가 있으면 좋을것 같다?
n (= 3, 4 ..) 이므로?

[dduneon]

고생하셨습니다