Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Default variables: configuration to Default variable details. #139

Open
ypid opened this issue May 23, 2016 · 3 comments
Open

Rename Default variables: configuration to Default variable details. #139

ypid opened this issue May 23, 2016 · 3 comments
Labels
approved enhancement

Comments

@ypid
Copy link
Member

ypid commented May 23, 2016

I think Default variable details is the better name for Default variables: configuration because this section explains complex role variables in more detail.

With this change I would also propose to rename the file from defaults-configuration.rst to defaults-detailed.rst. We could use this for new roles and adopt existing roles when reworking them.

Other names:

  • Complex variables explanation

What do you think?
@drybjed
Copy link
Member

drybjed commented May 23, 2016

Sure, it flows better in English, I suppose (not native speaker). Complex variables explanation is kind of out of the blue IMO, 'default variables' is a known thing in Ansible world.

@ypid
Copy link
Member Author

ypid commented May 23, 2016 •
edited
Loading

Default variable details it is then. Thanks. Maybe a native speaker English can take a look?

Copy paste area:

Filename: defaults-detailed.rst
Section heading: Default variable details

One liner to do the change:
mv defaults-configuration.rst defaults-detailed.rst; sed -i 's/defaults-configuration/defaults-detailed/' index.rst

@ypid ypid mentioned this issue May 28, 2016
Merged
ypid added a commit to ypid/ansible-preseed that referenced this issue May 28, 2016
@ypid
Renamed Default variables: configuration to `Default variable detai…
89b86ae 
…ls`.

Related to debops/docs#139
@ypid
Copy link
Member Author

ypid commented Jun 11, 2016

@drybjed Can you reopen? I forgot that GitHub auto closes this issue because of my commit message.

@drybjed drybjed reopened this Jun 11, 2016
ypid added a commit to ypid/ansible-apt_preferences that referenced this issue Jun 14, 2016
@ypid
Rename Default variables: configuration to Default variable details.
a24b8b3 
Related to debops/docs#139
ypid added a commit to ypid/ansible-ifupdown that referenced this issue Jun 14, 2016
@ypid
Rename Default variables: configuration to Default variable details.
9ed06ef 
Related to debops/docs#139
ypid added a commit to ypid/ansible-tinc that referenced this issue Jun 14, 2016
@ypid
Rename Default variables: configuration to Default variable details.
2c7c8e5 
Related to debops/docs#139
@ypid ypid added the approved label Jun 18, 2016
ypid added a commit to ypid/ansible-unattended_upgrades that referenced this issue Jul 8, 2016
@ypid
Rename Default variables: configuration to Default variable details.
6a96fbb 
Related to: debops/docs#139
ganto added a commit to ganto/ansible-checkmk_agent that referenced this issue Nov 2, 2016
@ganto
Update documentation according to latest guidelines
91aa1c1 
Also see:
- debops/docs#139
- debops/docs#155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drybjed @ypid