-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit actually limits to one less #3
Comments
cadecairos
pushed a commit
to cadecairos/express-limiter
that referenced
this issue
Sep 2, 2014
@cadecairos why don't you add a pull request? |
I was planning on it, but never had a chance. I'll see if I can help out next time I'm at my computer :) |
Hahahaha I did submit a patch, it's #4 |
Awesome. Thanks! ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
express-limiter/index.js
Line 37 in 99c10ed
You will always be limited to one less than the limit you set. For example, if I set limit to
1
it will decrementremaining
, save the JSON to Redis, and then once it hits the line above, remaining will be 0 and it sends a 429 response.The text was updated successfully, but these errors were encountered: