Skip to content

Commit 0d67a82

Browse files
committed
upgraded to jvm 21 and barrage 0.32.0
1 parent 5326fee commit 0d67a82

File tree

7 files changed

+20
-17
lines changed

7 files changed

+20
-17
lines changed

.github/resources/adhoc-scale-benchmark.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ default.completion.timeout=10 minutes
2121
generator.pause.per.row=0 millis
2222

2323
# Compression used for generating and storing records (SNAPPY, ZSTD, LZ4, LZO, GZIP, NONE)
24-
record.compression=SNAPPY
24+
record.compression=LZO
2525

2626
# Row count to scale tests (Tests can override but typically do not)
2727
scale.row.count=${baseRowCount}

.github/resources/compare-scale-benchmark.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ default.completion.timeout=10 minutes
2121
generator.pause.per.row=0 millis
2222

2323
# Compression used for generating and storing records (SNAPPY, ZSTD, LZ4, LZO, GZIP, NONE)
24-
record.compression=SNAPPY
24+
record.compression=LZO
2525

2626
# Row count to scale tests (Tests can override but typically do not)
2727
scale.row.count=70000000

.github/scripts/setup-test-server-remote.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ title "- Setting Up Remote Benchmark Testing on ${HOST} -"
3131
title "-- Adding OS Applications --"
3232
apt update
3333

34-
title "-- Installing JDK 17 --"
35-
apt install openjdk-17-jre-headless
34+
title "-- Installing JDK 21 --"
35+
apt install openjdk-21-jre-headless
3636

3737
title "-- Installing Maven --"
3838
apt install maven

.github/workflows/mvn-integration-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ jobs:
1515

1616
steps:
1717
- uses: actions/checkout@v3
18-
- name: Set up JDK 17
18+
- name: Set up JDK 21
1919
uses: actions/setup-java@v3
2020
with:
21-
java-version: '17'
21+
java-version: '21'
2222
distribution: 'temurin'
2323
cache: maven
2424

.github/workflows/remote-benchmarks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ jobs:
4747

4848
steps:
4949
- uses: actions/checkout@v3
50-
- name: Set up JDK 17
50+
- name: Set up JDK 21
5151
uses: actions/setup-java@v3
5252
with:
53-
java-version: '17'
53+
java-version: '21'
5454
distribution: 'temurin'
5555
cache: maven
5656

pom.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@
5151
<artifactId>maven-compiler-plugin</artifactId>
5252
<version>3.11.0</version>
5353
<configuration>
54-
<source>17</source>
55-
<target>17</target>
54+
<source>21</source>
55+
<target>21</target>
5656
</configuration>
5757
</plugin>
5858
<plugin>
@@ -210,12 +210,12 @@
210210
<dependency>
211211
<groupId>io.deephaven</groupId>
212212
<artifactId>deephaven-java-client-barrage-dagger</artifactId>
213-
<version>0.31.0</version>
213+
<version>0.32.0</version>
214214
</dependency>
215215
<dependency>
216216
<groupId>io.deephaven</groupId>
217217
<artifactId>deephaven-log-to-slf4j</artifactId>
218-
<version>0.31.0</version>
218+
<version>0.32.0</version>
219219
</dependency>
220220
<dependency>
221221
<groupId>org.junit.platform</groupId>

src/main/java/io/deephaven/benchmark/controller/DeephavenDockerController.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
/* Copyright (c) 2022-2023 Deephaven Data Labs and Patent Pending */
1+
/* Copyright (c) 2022-2024 Deephaven Data Labs and Patent Pending */
22
package io.deephaven.benchmark.controller;
33

44
import java.net.HttpURLConnection;
5-
import java.net.MalformedURLException;
5+
import java.net.URI;
66
import java.net.URL;
77
import java.nio.file.Path;
88
import java.nio.file.Paths;
@@ -75,12 +75,15 @@ public boolean restartService() {
7575
}
7676

7777
/**
78-
* Get the docker compose log since starting the Deephaven service.
78+
* Get the docker compose log since starting the Deephaven service. If no docker compose is specified, do nothing,
79+
* since the logs will get progressively bigger without a restart.
7980
*
8081
* @return the text collected from docker compose log
8182
*/
8283
@Override
8384
public String getLog() {
85+
if (composePropPath.isBlank() || httpHostPort.isBlank())
86+
return "";
8487
var composePath = getRunningComposePath();
8588
if (composePath != null)
8689
return exec("sudo docker compose -f " + composePath + " logs");
@@ -114,8 +117,8 @@ boolean getUrlStatus(String uri) {
114117

115118
URL createUrl(String uri) {
116119
try {
117-
return new URL(uri);
118-
} catch (MalformedURLException e) {
120+
return new URI(uri).toURL();
121+
} catch (Exception e) {
119122
throw new RuntimeException("Bad URL: " + uri);
120123
}
121124
}

0 commit comments

Comments
 (0)