Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corner Case Determining Latest Benchmarks #229

Closed
stanbrub opened this issue Dec 11, 2023 · 0 comments · Fixed by #231
Closed

Corner Case Determining Latest Benchmarks #229

stanbrub opened this issue Dec 11, 2023 · 0 comments · Fixed by #231
Assignees
Labels
bug Something isn't working

Comments

@stanbrub
Copy link
Collaborator

For release queries, there is a function latest_comparable_benchmarks that returns only the latest benchmarks that have greater than two versions. This is to avoid having obsolete benchmarks or brand new benchmarks that have nothing to compare.

This is achieved, because of a lack of build number in the product, by taking the timestamps of the benchmarks and converting them to an epoch day. The idea is to grab only benchmarks for the most recent day.

The problem is that sometimes adhoc benchmarks will be within a day local time but span days UTC. So some benchmarks get weeded out that shouldn't. (It doesn't look like this problem affect nightly runs, because they are run in the wee hours of the morning U.S.)

  • Broaden the epoch day to cover some of the next day
  • Parquet between 0.29.0 and 0.30.0 has obsolete and new benchmarks.
@stanbrub stanbrub added the bug Something isn't working label Dec 11, 2023
@stanbrub stanbrub self-assigned this Dec 11, 2023
@stanbrub stanbrub linked a pull request Dec 11, 2023 that will close this issue
@stanbrub stanbrub linked a pull request Dec 11, 2023 that will close this issue
@stanbrub stanbrub removed a link to a pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant