Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warmup Change Slowed UpdateBy #388

Closed
stanbrub opened this issue Nov 25, 2024 · 0 comments · Fixed by #389
Closed

Warmup Change Slowed UpdateBy #388

stanbrub opened this issue Nov 25, 2024 · 0 comments · Fixed by #389
Assignees
@stanbrub
Labels
bug Something isn't working

Comments

@stanbrub
Copy link
Collaborator

After merging PR #385 some benchmarks had major regressions. There are two possible issues here:

  • The incFactor for incremental release benchmarks is not being respected
  • Using head(rowCount) degrades performance

The first can be fixed. The second can be worked around, but the question is whether or not it is a DH engine inefficiency.
@stanbrub stanbrub added the bug Something isn't working label Nov 25, 2024
@stanbrub stanbrub self-assigned this Nov 25, 2024
@stanbrub stanbrub linked a pull request Nov 26, 2024 that will close this issue
fix: Warmups Code Revamp #389
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stanbrub stanbrub

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Warmups Code Revamp stanbrub/benchmark
1 participant
@stanbrub