Skip to content

Commit 4b8bbb9

Browse files
committed
ci: use lintspec instead of natspec-smells
1 parent 4d958f2 commit 4b8bbb9

File tree

5 files changed

+17
-540
lines changed

5 files changed

+17
-540
lines changed

.github/workflows/tests.yml

+10
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,12 @@ jobs:
123123
with:
124124
version: stable
125125

126+
- name: Install lintspec via cargo
127+
uses: baptiste0928/cargo-install@v3
128+
with:
129+
crate: lintspec
130+
version: '0.3.0'
131+
126132
- name: Use Node.js
127133
uses: actions/setup-node@v4
128134
with:
@@ -132,4 +138,8 @@ jobs:
132138
- name: Install dependencies
133139
run: yarn --frozen-lockfile --network-concurrency 1
134140

141+
- name: Run solhint and forge-fmt
135142
- run: yarn lint:check
143+
144+
- name: Run lintspec
145+
- run: yarn lint:natspec

README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@
3636

3737
1. Install Foundry by following the instructions from [their repository](https://github.com/foundry-rs/foundry#installation).
3838
2. Copy the `.env.example` file to `.env` and fill in the variables.
39-
3. Install the dependencies by running: `yarn install`. In case there is an error with the commands, run `foundryup` and try them again.
39+
3. Install rust dependencies: `cargo install lintspec`
40+
4. Install the dependencies by running: `yarn install`. In case there is an error with the commands, run `foundryup` and try them again.
4041

4142
## Build
4243

natspec-smells.config.js

-9
This file was deleted.

package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"deploy:sepolia": "bash -c 'source .env && forge script Deploy --rpc-url $SEPOLIA_RPC --account $SEPOLIA_DEPLOYER_NAME --broadcast --verify --chain sepolia -vvvvv'",
1818
"lint:check": "yarn lint:sol && forge fmt --check",
1919
"lint:fix": "sort-package-json && forge fmt && yarn lint:sol --fix",
20-
"lint:natspec": "npx @defi-wonderland/natspec-smells --config natspec-smells.config.js",
20+
"lint:natspec": "lintspec src",
2121
"lint:sol": "solhint 'src/**/*.sol' 'script/**/*.sol' 'test/**/*.sol'",
2222
"prepare": "husky",
2323
"test": "forge test -vvv",
@@ -35,7 +35,6 @@
3535
"devDependencies": {
3636
"@commitlint/cli": "19.3.0",
3737
"@commitlint/config-conventional": "19.2.2",
38-
"@defi-wonderland/natspec-smells": "1.1.6",
3938
"forge-std": "github:foundry-rs/forge-std#1.9.2",
4039
"halmos-cheatcodes": "github:a16z/halmos-cheatcodes#c0d8655",
4140
"husky": ">=9",

0 commit comments

Comments
 (0)