Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo Fixes in File Paths and Model Names Folder #1

Open
j-jayes opened this issue Sep 14, 2023 · 0 comments
Open

Typo Fixes in File Paths and Model Names Folder #1

j-jayes opened this issue Sep 14, 2023 · 0 comments

Comments

@j-jayes
Copy link

j-jayes commented Sep 14, 2023

Hello,

First of all, thank you for open-sourcing your work. I'm eager to dive into it!

While setting things up, I stumbled upon a couple of small typos:

  1. File : ca_metadata_utils.py
  • Current : LANGUAGES_FILE = '/img2txt_pipeline/utils/iso_639_2_languages.json
  • Suggestion : LANGUAGES_FILE = '/src/utils/iso_639_2_languages.json
  1. File : process_scans.sh
  • Current : --checkpoint_path_line american_stores_models/line_model_new.onnx
  • Suggestion : --checkpoint_path_line american_stories_models/line_model_new.onnx

It would be great if these can be corrected. Thank you for your time and efforts!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@j-jayes