deprecate managementServers, storageArrays, and defaultCredentialsSecret.

- add logic to dynamically create envs for defaultCredentialsSecret for backward compat only.
- remove final reference to X_CSI_POWERMAX_ENDPOINT.

Author: lukeatdell

charts/csi-powermax/templates/controller.yaml

@@ -414,6 +414,7 @@ spec:
               value: /var/run/csi/csi.sock
             - name: X_CSI_MODE
               value: controller
+              {{- if empty .Values.csireverseproxy.secretName }}
             - name: X_CSI_POWERMAX_USER
               valueFrom:
                 secretKeyRef:
@@ -424,6 +425,7 @@ spec:
                 secretKeyRef:
                   name: {{ .Values.global.defaultCredentialsSecret }}
                   key: password
+              {{- end }}
             - name: X_CSI_POWERMAX_CONFIG_PATH
               value: /powermax-config-params/driver-config-params.yaml
             - name: X_CSI_POWERMAX_ARRAY_CONFIG_PATH

charts/csi-powermax/templates/node.yaml

@@ -153,15 +153,13 @@ spec:
               value: "{{ .Values.maxPowerMaxVolumesPerNode }}"
             - name: X_CSI_PRIVATE_MOUNT_DIR
               value: "{{ .Values.kubeletConfigDir }}/plugins/powermax.emc.dell.com/disks"
-            {{- $managementServer := first .Values.global.managementServers }}
-            - name: X_CSI_POWERMAX_ENDPOINT
-              value: {{ required "Must provide a Unisphere HTTPS endpoint." $managementServer.endpoint }}
             - name: X_CSI_POWERMAX_DEBUG
               value: {{ .Values.powerMaxDebug | default "false" | lower | quote }}
             - name: X_CSI_POWERMAX_SKIP_CERTIFICATE_VALIDATION
               value: {{ .Values.skipCertificateValidation | default "true" | lower | quote }}
             - name: X_CSI_K8S_CLUSTER_PREFIX
               value:  {{ required "Must provide a Cluster Prefix." .Values.clusterPrefix }}
+              {{- if empty .Values.csireverseproxy.secretName }}
             - name: X_CSI_POWERMAX_USER
               valueFrom:
                 secretKeyRef:
@@ -172,6 +170,7 @@ spec:
                 secretKeyRef:
                   name: {{ .Values.global.defaultCredentialsSecret }}
                   key: password
+              {{- end }}
             - name: X_CSI_POWERMAX_NODENAME
               valueFrom:
                 fieldRef:

charts/csi-powermax/values.yaml

@@ -19,7 +19,12 @@ global:
   # Default value: None
   # Examples: "000000000001", "000000000002"
   managedArrays: "000000000001,000000000002"
+
   # defaultCredentialsSecret
+  # DEPRECATION NOTICE: The defaultCredentials parameter has been deprecated and will be
+  # removed in a future release. It remains for backward compatibility only.
+  # Please see use the parameter .csireverseproxy.secretName below and refer to the official
+  # documentation website for further details.
   defaultCredentialsSecret: powermax-creds
   # portGroups: Define the set of existing port groups that the driver will use.
   # It is a comma separated list of portgroup names.
@@ -37,13 +42,23 @@ global:
   #   ""      - Automatic selection of transport protocol
   # Default value: "" <empty>
   transportProtocol: ""
+
+  # DEPRECATION NOTICE: The storageArrays parameter has been deprecated in this helm chart
+  # and will be removed in a future release. It remains for backward compatibility only.
+  # storageArrays have been migrated to the 'secret' format. Please refer to the official
+  # documentation website for further details.
   storageArrays:
     - storageArrayId: "000000000001"
       endpoint: https://primary-1.unisphe.re:8443
       backupEndpoint: https://backup-1.unisphe.re:8443
   # - storageArrayId: "000000000002"
   #   endpoint: https://primary-2.unisphe.re:8443
   #   backupEndpoint: https://backup-2.unisphe.re:8443
+
+  # DEPRECATION NOTICE: The managementServers parameter has been deprecated in this helm chart
+  # and will be removed in a future release. It remains for backward compatibility only.
+  # managementServers have been migrated to the 'secret' format. Please refer to the official
+  # documentation website for further details.
   managementServers:
     - endpoint: https://primary-1.unisphe.re:8443
       credentialsSecret: primary-1-secret