Ensure state and actual resource are consistent (#245)

- Ensure state and actual resources are consistent for partial update
- Update NVMe related datasource/resource docs
- Update dependencies

Author: baoy1

docs/data-sources/nvme_host.md

@@ -26,6 +26,9 @@ description: |-
 
 This datasource is used to query the existing NVMe hosts from the PowerFlex array. The information fetched from this datasource can be used for getting the details / for further processing in resource block.
 
+> **Note:** 
+  NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore this datasource is not supported in PowerFlex 3.x.
+
 ## Example Usage
 
 ```terraform
@@ -55,6 +58,8 @@ data "powerflex_nvme_host" "example1" {
 // If multiple filter fields are provided then it will show the intersection of all of those fields.
 // If there is no intersection between the filters then an empty datasource will be returned
 // For more information about how we do our datasource filtering check out our guides: https://dell.github.io/terraform-docs/docs/storage/platforms/powerflex/product_guide/examples/ 
+// Please note that NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore this datasource is not supported in PowerFlex 3.x.
+
 data "powerflex_nvme_host" "example2" {
   filter {
     name = ["name1", "name2"]

docs/data-sources/nvme_target.md

@@ -26,6 +26,9 @@ description: |-
 
 This datasource is used to query the existing NVMe targets from the PowerFlex array. The information fetched from this datasource can be used for getting the details / for further processing in resource block.
 
+> **Note:** 
+  NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore this datasource is not supported in PowerFlex 3.x.
+
 ## Example Usage
 
 ```terraform
@@ -55,6 +58,8 @@ data "powerflex_nvme_target" "example1" {
 // If multiple filter fields are provided then it will show the intersection of all of those fields.
 // If there is no intersection between the filters then an empty datasource will be returned
 // For more information about how we do our datasource filtering check out our guides: https://dell.github.io/terraform-docs/docs/storage/platforms/powerflex/product_guide/examples/ 
+// Please note that NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore this datasource is not supported in PowerFlex 3.x.
+
 data "powerflex_nvme_target" "example" {
   filter {
     name = ["name1", "name2"]

docs/resources/cluster.md

@@ -46,6 +46,8 @@ This terraform resource is used to deploy the PowerFlex Cluster. We can Create a
 
 9. To follow the installation process, you can refer to the [Deployment Guide 3.x](https://www.dell.com/support/manuals/en-us/scaleio/pfx_deploy_guide_3.6.x/deploy-powerflex?guid=guid-e9f70972-baac-42c9-9ff9-a3d2b0722f54&lang=en-us) & [Deployment Guide 4.x](https://www.dell.com/support/manuals/en-us/scaleio/powerflex_install_upgrade_guide_4.5.x/introduction?guid=guid-e798f431-7df4-450c-8f86-60ee7f3d1e3e&lang=en-us)
 
+10. NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore SDT deployment is not supported in PowerFlex 3.x.
+
 ## Example Usage
 
 ```terraform

docs/resources/nvme_host.md

@@ -26,7 +26,10 @@ description: |-
 
 This resource is used to manager NVMe host from the PowerFlex array. We can Create, Update and Delete the PowerFlex NVMe host using this resource. We can also import an existing NVMe host from PowerFlex array.
 
-Please note that due to certain limitations, updating the NVMe host in PowerFlex versions earlier than 4.6 is not supported
+> **Note:** 
+>  - NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore this resource is not supported in PowerFlex 3.x.
+>  - Due to certain limitations, updating the NVMe host in PowerFlex versions earlier than 4.6 is not supported
+
 
 ## Example Usage
 
@@ -53,7 +56,9 @@ limitations under the License.
 # To import , check import.sh for more info
 # nqn is the required parameter to create
 # To check which attributes can be updated, please refer Product Guide in the documentation
-# Please note that due to certain limitations, updating the NVMe host in PowerFlex versions earlier than 4.6 is not supported
+# Please note that 
+# 1. NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore this resource is not supported in PowerFlex 3.x.
+# 2. Due to certain limitations, updating the NVMe host in PowerFlex versions earlier than 4.6 is not supported
 
 # Example for adding NVMe host.
 resource "powerflex_nvme_host" "test-nvme-host" {

docs/resources/nvme_target.md

@@ -27,7 +27,14 @@ description: |-
 This resource is used to manager NVMe target from the PowerFlex array. We can Create, Update and Delete the PowerFlex NVMe target using this resource. We can also import an existing NVMe target from PowerFlex array.  
  **Note:** Either `protection_domain_id` or `protection_domain_name` must be specified.
 
-To avoid potential issues, it is recommended to operate NVMe targets using the default ports.
+> **Caution:** <span style='color: red;' >NVMe target creation or update is not atomic. In case of partially completed create operations, terraform can mark the resource as tainted.
+One can manually remove the taint and try applying the configuration (after making necessary adjustments).
+If the taint is not removed, terraform will destroy and recreate the resource.</span>
+
+> **Note:** 
+>  - Either `protection_domain_name` and `protection_domain_id` is required. But not both.
+>  - NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore this resource is not supported in PowerFlex 3.x.
+>  - To avoid potential issues, it is recommended to operate NVMe targets using the default ports.
 
 ## Example Usage
 
@@ -54,6 +61,7 @@ limitations under the License.
 # To import , check import.sh for more info.
 # name and ip_list attributes are required, and either protection_domain_name or protection_domain_id must be specified.
 # To check which attributes can be updated, please refer Product Guide in the documentation
+# Please note that NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore this resource is not supported in PowerFlex 3.x.
 # To avoid potential issues, it is recommended to operate NVMe targets using the default ports.
 
 # Example for adding NVMe target.

examples/data-sources/powerflex_nvme_host/data-source.tf

@@ -24,6 +24,8 @@ data "powerflex_nvme_host" "example1" {
 // If multiple filter fields are provided then it will show the intersection of all of those fields.
 // If there is no intersection between the filters then an empty datasource will be returned
 // For more information about how we do our datasource filtering check out our guides: https://dell.github.io/terraform-docs/docs/storage/platforms/powerflex/product_guide/examples/ 
+// Please note that NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore this datasource is not supported in PowerFlex 3.x.
+
 data "powerflex_nvme_host" "example2" {
   filter {
     name = ["name1", "name2"]

examples/data-sources/powerflex_nvme_target/data-source.tf

@@ -24,6 +24,8 @@ data "powerflex_nvme_target" "example1" {
 // If multiple filter fields are provided then it will show the intersection of all of those fields.
 // If there is no intersection between the filters then an empty datasource will be returned
 // For more information about how we do our datasource filtering check out our guides: https://dell.github.io/terraform-docs/docs/storage/platforms/powerflex/product_guide/examples/ 
+// Please note that NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore this datasource is not supported in PowerFlex 3.x.
+
 data "powerflex_nvme_target" "example" {
   filter {
     name = ["name1", "name2"]

examples/resources/powerflex_nvme_host/resource.tf

@@ -20,7 +20,9 @@ limitations under the License.
 # To import , check import.sh for more info
 # nqn is the required parameter to create
 # To check which attributes can be updated, please refer Product Guide in the documentation
-# Please note that due to certain limitations, updating the NVMe host in PowerFlex versions earlier than 4.6 is not supported
+# Please note that 
+# 1. NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore this resource is not supported in PowerFlex 3.x.
+# 2. Due to certain limitations, updating the NVMe host in PowerFlex versions earlier than 4.6 is not supported
 
 # Example for adding NVMe host.
 resource "powerflex_nvme_host" "test-nvme-host" {

examples/resources/powerflex_nvme_target/resource.tf

@@ -20,6 +20,7 @@ limitations under the License.
 # To import , check import.sh for more info.
 # name and ip_list attributes are required, and either protection_domain_name or protection_domain_id must be specified.
 # To check which attributes can be updated, please refer Product Guide in the documentation
+# Please note that NVMe over TCP is supported in PowerFlex 4.0 and later versions, therefore this resource is not supported in PowerFlex 3.x.
 # To avoid potential issues, it is recommended to operate NVMe targets using the default ports.
 
 # Example for adding NVMe target.

go.mod

@@ -8,15 +8,15 @@ require (
 	github.com/bramvdbogaerde/go-scp v1.5.0
 	github.com/bytedance/mockey v1.2.13
 	github.com/dell/goscaleio v1.17.1-0.20241116014606-58a85e67edac
-	github.com/hashicorp/terraform-plugin-framework v1.11.0
-	github.com/hashicorp/terraform-plugin-framework-validators v0.13.0
-	github.com/hashicorp/terraform-plugin-go v0.23.0
+	github.com/hashicorp/terraform-plugin-framework v1.13.0
+	github.com/hashicorp/terraform-plugin-framework-validators v0.15.0
+	github.com/hashicorp/terraform-plugin-go v0.25.0
 	github.com/hashicorp/terraform-plugin-log v0.9.0
 	github.com/hashicorp/terraform-plugin-testing v1.10.0
 	github.com/masterzen/winrm v0.0.0-20240702205601-3fad6e106085
 	github.com/packer-community/winrmcp v0.0.0-20221126162354-6e900dd2c68f
 	github.com/stretchr/testify v1.9.0
-	golang.org/x/crypto v0.26.0
+	golang.org/x/crypto v0.29.0
 )
 
 require (
@@ -57,9 +57,9 @@ require (
 	github.com/vmihailenco/tagparser/v2 v2.0.0 // indirect
 	golang.org/x/arch v0.11.0 // indirect
 	golang.org/x/mod v0.19.0 // indirect
-	golang.org/x/sync v0.8.0 // indirect
+	golang.org/x/sync v0.9.0 // indirect
 	golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d // indirect
-	google.golang.org/genproto/googleapis/rpc v0.0.0-20240227224415-6ceb2ff114de // indirect
+	google.golang.org/genproto/googleapis/rpc v0.0.0-20240814211410-ddb44dafa142 // indirect
 	gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
@@ -76,7 +76,7 @@ require (
 	github.com/hashicorp/go-cty v1.4.1-0.20200414143053-d3edf31b6320 // indirect
 	github.com/hashicorp/go-hclog v1.6.3 // indirect
 	github.com/hashicorp/go-multierror v1.1.1 // indirect
-	github.com/hashicorp/go-plugin v1.6.0 // indirect
+	github.com/hashicorp/go-plugin v1.6.2 // indirect
 	github.com/hashicorp/go-uuid v1.0.3 // indirect
 	github.com/hashicorp/go-version v1.7.0 // indirect
 	github.com/hashicorp/hc-install v0.8.0 // indirect
@@ -94,12 +94,12 @@ require (
 	github.com/sirupsen/logrus v1.9.3 // indirect
 	github.com/vmihailenco/msgpack v4.0.4+incompatible // indirect
 	github.com/zclconf/go-cty v1.15.0 // indirect
-	golang.org/x/net v0.25.0 // indirect
+	golang.org/x/net v0.28.0 // indirect
 	golang.org/x/sys v0.27.0 // indirect
-	golang.org/x/text v0.17.0 // indirect
+	golang.org/x/text v0.20.0 // indirect
 	google.golang.org/appengine v1.6.8 // indirect
-	google.golang.org/grpc v1.63.2 // indirect
-	google.golang.org/protobuf v1.34.0 // indirect
+	google.golang.org/grpc v1.67.1 // indirect
+	google.golang.org/protobuf v1.35.1 // indirect
 )
 
 exclude gopkg.in/yaml.v2 v2.2.2