Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove action should have an optional stats field #567

Open
OussamaSaoudi-db opened this issue Dec 6, 2024 · 0 comments · May be fixed by #633
Open

Remove action should have an optional stats field #567

OussamaSaoudi-db opened this issue Dec 6, 2024 · 0 comments · May be fixed by #633
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@OussamaSaoudi-db
Copy link
Collaborator

Please describe why this is necessary.

The delta protocol states that remove actions have an optional stats field

Presently, this field is missing in delta_kernel::actions::Remove.

Describe the functionality you are proposing.

Add the stats field to Remove, update the RemoveVisitor, and add a test to verify that DataSkippingFilter correctly filters out remove actions when they do not match a predicate.

Check that Remove actions are properly filtered in log replay tests for CDF kernel/src/table_changes/log_replay/tests.rs

Additional context

No response

@OussamaSaoudi-db OussamaSaoudi-db added enhancement New feature or request good first issue Good for newcomers labels Dec 6, 2024
@sebastiantia sebastiantia linked a pull request Jan 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants