perf: close partition writers concurrently #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y partitions (cherry picked from commit af17bb2) Signed-off-by: Alex Wilcoxson <alex.wilcoxson@relativity.com> chore: fmt
alexwilcoxson-rel
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
==========================================
- Coverage 72.26% 72.25% -0.01%
==========================================
Files 128 128
Lines 40329 40336 +7
Branches 40329 40336 +7
==========================================
+ Hits 29143 29145 +2
- Misses 9334 9335 +1
- Partials 1852 1856 +4 ☔ View full report in Codecov by Sentry. |
rtyler
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an edge case of having a delta writer with many partitions, the close operation can be quite slow as it closes the inner partition writers serially. This change makes the close concurrent.
Related Issue(s)
n/a
Documentation
n/a