Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error reporting wrt human_panic #196

Closed
dignifiedquire opened this issue Jul 17, 2019 · 2 comments
Closed

Improve error reporting wrt human_panic #196

dignifiedquire opened this issue Jul 17, 2019 · 2 comments

Comments

@dignifiedquire
Copy link
Member

While human_panic is great, it has some drawbacks on mobile devices.

I suggest using the code posted here rust-cli/human-panic#62 (comment) instead, to print the details to the stdlogs, possibly in addition to a file on Desktop.
@dignifiedquire
Copy link
Member Author

we should include git commit in there, while we are at it

@hpk42 hpk42 changed the title Improve error reporting Improve error reporting wrt human_panic Jul 26, 2019
@hpk42
Copy link
Contributor

hpk42 commented Jul 13, 2020

as we very rarely get crashes (hardly any unsafe code left) and if so, from users who don't run in debug, human_panic is not that important to improve anymore i guess. At least no dev felt the need to go for this improvement for one year now.

@hpk42 hpk42 closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hpk42 @dignifiedquire