Syntax highlighting for deno.lock
files on GitHub
#21119
Closed
spenserblack
started this conversation in
General
Replies: 1 comment
-
Well, PR is merged, so I'm closing. But if the community ever feels like this file should be marked as generated (or have another attribute), that can always be changed in a separate PR. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi, deno community 👋
After noticing that
deno.lock
files were not getting highlighted on github.com, I decided to add support with this PR: github-linguist/linguist#6590. I wanted to reach out to the Deno community to provide a chance for feedback (please let me know if there's a better way to reach out).One of the things that linguist does is detect if files are generated. If they are generated, they are excluded from GitHub PR diffs by default. So while lock files are almost always generated, there are special cases where they aren't marked as generated, as some communities believe you should review lock files. For example,
Cargo.lock
is marked as generated, butyarn.lock
was changed to not be marked as generated. It really seems to come down to the preference of the package manager's community and maintainers. tl;dr the question is: shoulddeno.lock
be marked as generated and excluded from GitHub PR diffs by default?Beta Was this translation helpful? Give feedback.
All reactions