Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno 2.0 nodeModulesDir :"auto" conflicting with true #2715

Open
Priyansh4444 opened this issue Oct 17, 2024 · 1 comment
Open

Deno 2.0 nodeModulesDir :"auto" conflicting with true #2715

Priyansh4444 opened this issue Oct 17, 2024 · 1 comment
Labels
deploy Issues/Questions surrounding Deno Deploy upstream The issue is with an upstream dependency.

Comments

@Priyansh4444
Copy link

Priyansh4444 commented Oct 17, 2024

Describe the bug
While first running fresh I was given this warning:

Warning `"nodeModulesDir": true` is deprecated in Deno 2.0. Use `"nodeModulesDir": "auto"` instead
    at /PowerpointScraper/powerpoint_scraper/deno.json

and so I changed it accordingly to auto

But then when I tried to do go and deploy the project using deno deploy,
in github actions I got this error

Failed deserializing config file '/PowerpointScraper/PowerpointScraper/deno.json'.

Caused by:
    invalid type: string "true", expected a boolean

To Reproduce

  1. Start a fresh "fresh" project
  2. Run using deno task start
  3. Get Warning
  4. Deno Deploy and deploy the project providing no github manual github actions
  5. Fail the Build step because of error mentioned

Expected behavior

I did not expect the build step to fail
I am assuming this is something to do with a type error which could not be handled

Screenshots

If applicable, add screenshots to help explain your problem.
image
image

Versions

vscode: 1.94.2 deno: 2.0.0 extension: 3.42.0

With guidance I would love to help and fix the issue since I want to contribute to this since I had a lot of fun working with deno and fresh 😄

@Priyansh4444 Priyansh4444 changed the title Deno 2.0 "auto" Deno 2.0 "auto" conflicting with true Oct 17, 2024
@Priyansh4444 Priyansh4444 changed the title Deno 2.0 "auto" conflicting with true Deno 2.0 nodeModulesDir :"auto" conflicting with true Oct 17, 2024
@nayeemrmn nayeemrmn transferred this issue from denoland/vscode_deno Oct 17, 2024
@marvinhagemeister
Copy link
Collaborator

Thanks for reporting this issue. Deno Deploy currently supports Deno 1.x . Support for Deno 2 will land soon.

@marvinhagemeister marvinhagemeister added deploy Issues/Questions surrounding Deno Deploy upstream The issue is with an upstream dependency. labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Issues/Questions surrounding Deno Deploy upstream The issue is with an upstream dependency.
Projects
None yet
Development

No branches or pull requests

2 participants