Skip to content

Inconsistent use of the poed system lock #9

@rothcar

Description

@rothcar

Poed maintains a system-wide exclusive lock for access to the PoE chipset communications channel. This lock is maintained poorly and the error recovery for failed lock attempts is incorrect. This can lead invalid poed state.

  1. the try/except code that manages the exclusive lock includes the safe code path inside the lock exception handler. Meaning, the safe code path can throw an exception similar to the lock syscall and poed cannot tell the difference.
  2. Exception handling for a failed lock attempt does not provide adequate context to the user as to the failure cause or location
  3. Failed lock attempts are ignored (the safe code path result skipped).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions