Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Github action and its warnings #2721

Closed
Ponnia-M opened this issue Mar 8, 2024 · 4 comments
Closed

Track Github action and its warnings #2721

Ponnia-M opened this issue Mar 8, 2024 · 4 comments

Comments

@Ponnia-M
Copy link
Contributor

Ponnia-M commented Mar 8, 2024

As a VRO Engineer, we faced multiple warnings when it comes to deploying code through our pipelines. We investigated these warnings and fixed most of them so that we can deploy code more seamlessly. However, some workflows are still affected by this warnings:

I contacted the engineer in charge of maintaining this Github action, but got no response. This ticket is to maintain visibility and keep track of this issue and hopefully update it in the future.

Github Actions workflows affected by warnings above:

  1. Continuous Integration (CI) workflow => 26 warnings across various jobs
  2. CI: API Gateway integration test => 10 warnings (mostly deprecated 'set-output' command)
  3. CI: BIE Kafka End-2-End Test => 2 warnings
  4. CI: EE - EP Merge - Integration Test => 4 warnings
  5. CI: SVC BGS API integration test => 9 warnings
  6. CI: SVC BIP API integration test => 2 warnings
  7. Secrel => 6 warnings

Team agreed that we retired indiesdev/curl@v1.1 action and replace it with another since it's no longer managed consistently.

@Ponnia-M Ponnia-M self-assigned this Mar 8, 2024
@Ponnia-M
Copy link
Contributor Author

tspascoal/get-user-teams-membership@v3.0.0 is up to date and changes have been merged to develop branch

@Ponnia-M Ponnia-M added blocked a label for items that need unblocking and removed blocked a label for items that need unblocking labels Apr 2, 2024
@Ponnia-M Ponnia-M reopened this Apr 5, 2024
@Ponnia-M
Copy link
Contributor Author

Ponnia-M commented Apr 5, 2024

Created ticket to change private repo (curl-action) to public

@meganhicks meganhicks mentioned this issue Apr 7, 2024
22 tasks
@Ponnia-M
Copy link
Contributor Author

Ponnia-M commented Apr 9, 2024

Still waiting on approval from VA COR then update this ticket

@Ponnia-M
Copy link
Contributor Author

Created a new action in public VA repo. Below are links to affected workflows and no more node.js 16 errors come up anymore since these actions now run on Node.js 20:

  • BIE-Kakfa
  • BIP-API
  • BGS-API
  • EE-EP merge
  • API gateway
  • CI
  • Secrel => For clarity, all indiesdev/curl@v1.1 action warnings in our Secrel workflow have been resolved. However, the current node.js 16 warnings seen here are from another action (see picture below). Based on this conversation reverting back to v5 brought back these errors.

Screenshot 2024-04-04 at 1.24.09 AM.png

Here is the updated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants