Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependence on apivore #7572

Closed
2 tasks
erluti opened this issue Apr 3, 2020 · 3 comments
Closed
2 tasks

remove dependence on apivore #7572

erluti opened this issue Apr 3, 2020 · 3 comments
Labels
high priority platform-cop Issues that are in a Platform COP backlog platform-cop-backend for Platform CoP Backend

Comments

@erluti
Copy link
Contributor

erluti commented Apr 3, 2020

Problem Statement

How do we remove our dependency on apivore? It is no longer maintained and doesn't support Rails 6.

Objectives

  • Use only gems that support upgrading our system

Tasks

  • Review/Maintain test coverage provided from using apivore

Acceptance Criteria

  • no longer dependent on apivore
@erluti erluti added the tools-be Used for the backend tools team label Apr 3, 2020
@erluti
Copy link
Contributor Author

erluti commented Apr 3, 2020

Apivore is only used by spec/request/swagger_spec.rb. This spec makes requests to endpoints and compares responses to the swagger documentation. We can remove apivore with no issues if there's a way to set up an equivalent test.

@erluti
Copy link
Contributor Author

erluti commented Apr 6, 2020

I looked into using the committee gem because it has an assert_schema_conform test helper. It was failing to load the driver from our specs because of how we use #ref in the parameters.
WIP branch: https://github.com/department-of-veterans-affairs/vets-api/tree/be-tools/pb/use-committee-to-test-api-specs

Issue I created related to the driver failing to load our schema interagent/committee#259 for the committee gem.

@jeff2d2 jeff2d2 added be-temp and removed be-temp labels Aug 30, 2021
@npeterson54 npeterson54 added console-services Console Services Team (Platform Crew) and removed tools-be Used for the backend tools team labels Mar 10, 2022
@npeterson54 npeterson54 added platform-cop-backend for Platform CoP Backend and removed console-services Console Services Team (Platform Crew) labels Oct 7, 2022
@andreahewitt-odd andreahewitt-odd added the platform-cop Issues that are in a Platform COP backlog label Oct 28, 2022
@holdenhinkle
Copy link
Collaborator

It would be great if this could be completed in the next couple of sprints.

@holdenhinkle holdenhinkle closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority platform-cop Issues that are in a Platform COP backlog platform-cop-backend for Platform CoP Backend
Projects
None yet
Development

No branches or pull requests

5 participants