diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 83fd1803e94..18db205cd34 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,12 +1,12 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 100` -# on 2024-08-20 15:48:20 UTC using RuboCop version 1.65.1. +# on 2024-09-05 17:59:19 UTC using RuboCop version 1.66.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 157 +# Offense count: 154 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: Include, EnforcedStyle, ExplicitOnly. # Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb @@ -60,9 +60,6 @@ FactoryBot/ConsistentParenthesesStyle: - 'spec/models/va_profile_redis/cache_spec.rb' - 'spec/models/va_profile_redis/contact_information_spec.rb' - 'spec/rakelib/form526_spec.rb' - - 'spec/requests/form1095_b_spec.rb' - - 'spec/requests/service_history_request_spec.rb' - - 'spec/requests/va_profile/transactions_request_spec.rb' - 'spec/serializers/category_serializer_spec.rb' - 'spec/serializers/cemetery_serializer_spec.rb' - 'spec/serializers/lighthouse/facilities/facility_serializer_spec.rb' @@ -75,7 +72,7 @@ FactoryBot/ConsistentParenthesesStyle: - 'spec/sidekiq/form1095/new1095_bs_job_spec.rb' - 'spec/sidekiq/vre/create_ch31_submissions_report_job_spec.rb' -# Offense count: 592 +# Offense count: 594 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Include. # Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb @@ -88,7 +85,7 @@ Layout/EmptyLinesAroundExceptionHandlingKeywords: Exclude: - 'spec/controllers/v0/virtual_agent/virtual_agent_claim_spec.rb' -# Offense count: 205 +# Offense count: 200 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: space, no_space @@ -105,11 +102,9 @@ Layout/LineContinuationSpacing: - 'lib/generators/module_component/module_component_generator.rb' - 'modules/appeals_api/app/swagger/appeals_api/v1/notice_of_disagreements_controller_swagger.rb' - 'modules/appeals_api/spec/docs/decision_reviews/higher_level_reviews_spec.rb' - - 'modules/appeals_api/spec/requests/v2/supplemental_claims_controller_spec.rb' - 'modules/claims_api/app/controllers/concerns/claims_api/disability_compensation_validations.rb' - 'modules/claims_api/app/controllers/concerns/claims_api/poa_verification.rb' - 'modules/claims_api/app/sidekiq/claims_api/poa_vbms_updater.rb' - - 'modules/claims_api/spec/requests/v1/disability_compensation_request_spec.rb' - 'modules/mobile/spec/services/lighthouse_health_service_spec.rb' - 'modules/vba_documents/lib/vba_documents/upload_validator.rb' - 'spec/controllers/v1/sessions_controller_spec.rb' @@ -130,7 +125,7 @@ Layout/LineContinuationSpacing: - 'spec/sidekiq/cypress_viewport_updater/viewport_preset_js_file_spec.rb' - 'spec/support/saml/response_builder.rb' -# Offense count: 39 +# Offense count: 38 # This cop supports safe autocorrection (--autocorrect). Lint/AmbiguousOperatorPrecedence: Exclude: @@ -148,7 +143,6 @@ Lint/AmbiguousOperatorPrecedence: - 'modules/mobile/app/helpers/mobile/facilities_helper.rb' - 'rakelib/form526.rake' - 'spec/models/session_spec.rb' - - 'spec/requests/health_records_request_spec.rb' - 'spec/services/mhv_logging_service_spec.rb' - 'spec/sidekiq/cypress_viewport_updater/cypress_config_js_file_spec.rb' - 'spec/support/bb_client_helpers.rb' @@ -168,7 +162,7 @@ Lint/AmbiguousRange: - 'modules/claims_api/app/uploaders/claims_api/base_uploader.rb' - 'spec/uploaders/form1010cg/poa_uploader_spec.rb' -# Offense count: 72 +# Offense count: 70 # Configuration parameters: AllowedMethods. # AllowedMethods: enums Lint/ConstantDefinitionInBlock: @@ -184,7 +178,6 @@ Lint/ConstantDefinitionInBlock: - 'modules/vba_documents/spec/factories/upload_submissions.rb' - 'modules/vba_documents/spec/lib/multipart_parser_spec.rb' - 'modules/vba_documents/spec/mailers/unsuccessful_report_mailer_spec.rb' - - 'modules/vba_documents/spec/request/v2/uploads_request_submission_spec.rb' - 'rakelib/claims.rake' - 'rakelib/evss.rake' - 'rakelib/pension_burial.rake' @@ -209,7 +202,6 @@ Lint/ConstantDefinitionInBlock: - 'spec/lib/webhooks/utilities_spec.rb' - 'spec/models/webhooks/utilities_spec.rb' - 'spec/requests/authentication/standard_authentication_spec.rb' - - 'spec/requests/health_records_request_spec.rb' - 'spec/sidekiq/process_file_job_spec.rb' - 'spec/uploaders/log_metrics_spec.rb' - 'spec/uploaders/uploader_virus_scan_spec.rb' @@ -224,12 +216,6 @@ Lint/DuplicateBranch: - 'app/sidekiq/education_form/process10203_submissions.rb' - 'spec/controllers/v1/sessions_controller_spec.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Lint/DuplicateMagicComment: - Exclude: - - 'spec/requests/va_profile/address_request_spec.rb' - # Offense count: 2 # This cop supports safe autocorrection (--autocorrect). Lint/DuplicateRegexpCharacterClassElement: @@ -335,7 +321,7 @@ Lint/NoReturnInBeginEndBlocks: - 'modules/check_in/app/services/v2/chip/service.rb' - 'modules/mobile/app/models/mobile/v0/adapters/vaos_v2_appointment.rb' -# Offense count: 20 +# Offense count: 18 # This cop supports unsafe autocorrection (--autocorrect-all). Lint/NonAtomicFileOperation: Exclude: @@ -347,7 +333,6 @@ Lint/NonAtomicFileOperation: - 'modules/mobile/app/services/mobile/v0/claims/proxy.rb' - 'spec/controllers/v0/caregivers_assistance_claims_controller_spec.rb' - 'spec/models/form1010cg/attachment_spec.rb' - - 'spec/requests/caregivers_assistance_claims_request_spec.rb' - 'spec/rswag_override.rb' # Offense count: 4 @@ -386,7 +371,7 @@ Lint/RequireRangeParentheses: Exclude: - 'rakelib/form526.rake' -# Offense count: 1072 +# Offense count: 976 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, consistent @@ -411,8 +396,6 @@ Lint/SymbolConversion: - 'modules/check_in/spec/exceptions/check_in/v2/checkin_service_exception_spec.rb' - 'modules/claims_api/app/models/claims_api/auto_established_claim.rb' - 'modules/claims_api/lib/claims_api/evidence_waiver_pdf/pdf.rb' - - 'modules/claims_api/lib/claims_api/v2/mock_documents_service.rb' - - 'modules/claims_api/spec/requests/v1/disability_compensation_request_spec.rb' - 'modules/covid_vaccine/app/services/covid_vaccine/v0/expanded_registration_service.rb' - 'modules/covid_vaccine/spec/services/covid_vaccine/v0/expanded_registration_service_spec.rb' - 'modules/covid_vaccine/spec/sidekiq/covid_vaccine/expanded_submission_state_job_spec.rb' @@ -429,11 +412,8 @@ Lint/SymbolConversion: - 'modules/meb_api/spec/dgi/enrollment/service_spec.rb' - 'modules/meb_api/spec/requests/meb_api/v0/education_benefits_spec.rb' - 'modules/mobile/spec/models/adapters/appointments_vaos_v2_adapter_spec.rb' - - 'modules/mobile/spec/request/appointments_create_request_spec.rb' - 'modules/vaos/spec/factories/v2/appointment_forms.rb' - - 'modules/vaos/spec/request/v2/appointments_request_spec.rb' - 'modules/vba_documents/spec/factories/upload_submissions.rb' - - 'modules/vba_documents/spec/request/v2/uploads_request_spec.rb' - 'rakelib/mockdata_synchronize.rake' - 'spec/factories/coe_claim.rb' - 'spec/factories/form526_submissions.rb' @@ -447,7 +427,7 @@ Lint/UselessRescue: - 'app/controllers/v0/contact_us/inquiries_controller.rb' - 'lib/lgy/service.rb' -# Offense count: 1055 +# Offense count: 1072 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: Max: 90 @@ -458,21 +438,21 @@ Metrics/AbcSize: Metrics/BlockLength: Max: 86 -# Offense count: 247 +# Offense count: 249 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: Max: 29 -# Offense count: 187 +# Offense count: 185 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/PerceivedComplexity: Max: 29 -# Offense count: 294 +# Offense count: 288 Naming/AccessorMethodName: Enabled: false -# Offense count: 258 +# Offense count: 250 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns. # SupportedStyles: snake_case, normalcase, non_integer # AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64 @@ -499,11 +479,7 @@ Naming/VariableNumber: - 'modules/appeals_api/app/services/appeals_api/pdf_construction/higher_level_review/v2/form_fields.rb' - 'modules/appeals_api/app/swagger/appeals_api/v1/nod_json_schema_swagger_helper.rb' - 'modules/appeals_api/spec/lib/decision_review_report_spec.rb' - - 'modules/appeals_api/spec/requests/v2/higher_level_reviews_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/notice_of_disagreements_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/supplemental_claims_controller_spec.rb' - 'modules/appeals_api/spec/services/appeals_api/central_mail_updater_spec.rb' - - 'modules/check_in/spec/request/v2/sessions_request_spec.rb' - 'modules/claims_api/app/controllers/claims_api/v1/forms/disability_compensation_controller.rb' - 'modules/claims_api/app/controllers/claims_api/v1/forms/intent_to_file_controller.rb' - 'modules/claims_api/app/controllers/claims_api/v1/forms/power_of_attorney_controller.rb' @@ -536,7 +512,6 @@ Naming/VariableNumber: - 'spec/lib/decision_review/schemas_spec.rb' - 'spec/lib/facilities/drivetime_bands/client_spec.rb' - 'spec/lib/facilities/gis/client_spec.rb' - - 'spec/lib/preneeds/service_spec.rb' - 'spec/mailers/ch31_submissions_report_mailer_spec.rb' - 'spec/mailers/stem_applicant_denial_mailer_spec.rb' - 'spec/models/drivetime_band_spec.rb' @@ -560,21 +535,19 @@ Naming/VariableNumber: - 'spec/sidekiq/facilities/state_cemetery_reload_job_spec.rb' - 'spec/sidekiq/form1010cg/delete_old_uploads_job_spec.rb' -# Offense count: 1049 +# Offense count: 1074 # This cop supports unsafe autocorrection (--autocorrect-all). RSpec/BeEq: Enabled: false -# Offense count: 52 +# Offense count: 45 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: be, be_nil RSpec/BeNil: Exclude: - 'modules/appeals_api/spec/models/higher_level_review/phone_spec.rb' - - 'modules/appeals_api/spec/requests/v2/legacy_appeals_controller_spec.rb' - 'modules/claims_api/spec/models/auto_establish_claim_spec.rb' - - 'modules/claims_api/spec/requests/v2/veterans/claims_request_spec.rb' - 'modules/va_notify/spec/models/confirmation_email_spec.rb' - 'modules/vba_documents/spec/models/upload_submission_spec.rb' - 'modules/vba_documents/spec/sidekiq/upload_processor_spec.rb' @@ -598,7 +571,7 @@ RSpec/BeNil: - 'spec/services/sign_in/attribute_validator_spec.rb' - 'spec/sidekiq/webhooks/callback_url_job_spec.rb' -# Offense count: 13 +# Offense count: 11 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: NegatedMatcher. RSpec/ChangeByZero: @@ -608,10 +581,9 @@ RSpec/ChangeByZero: - 'spec/lib/sidekiq/form526_backup_submission_process/submit_spec.rb' - 'spec/models/form526_submission_spec.rb' - 'spec/models/saved_claim/education_benefits/va10203_spec.rb' - - 'spec/requests/letters_request_spec.rb' - 'spec/sidekiq/in_progress_form_cleaner_spec.rb' -# Offense count: 27 +# Offense count: 25 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: be_a, be_kind_of @@ -622,46 +594,22 @@ RSpec/ClassCheck: - 'spec/lib/common/models/redis_store_spec.rb' - 'spec/lib/iam_ssoe_oauth/session_manager_spec.rb' -# Offense count: 67 +# Offense count: 17 # This cop supports safe autocorrection (--autocorrect). RSpec/ExcessiveDocstringSpacing: Exclude: - - 'modules/appeals_api/spec/requests/v1/notice_of_disagreements_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/higher_level_reviews_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/notice_of_disagreements_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/supplemental_claims_controller_spec.rb' - 'modules/check_in/spec/services/v2/lorota/service_spec.rb' - 'modules/claims_api/spec/models/auto_establish_claim_spec.rb' - - 'modules/claims_api/spec/requests/v1/disability_compensation_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/intent_to_file_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/power_of_attorney_request_spec.rb' - - 'modules/claims_api/spec/requests/v2/veterans/claims_request_spec.rb' - - 'modules/dhp_connected_devices/spec/controllers/dhp_connected_devices/fitbit/fitbit_controller_spec.rb' - 'modules/dhp_connected_devices/spec/services/dhp_connected_devices/token_storage_service_spec.rb' - - 'modules/health_quest/spec/request/lighthouse_appointments_request_spec.rb' - - 'modules/health_quest/spec/request/locations_request_spec.rb' - - 'modules/health_quest/spec/request/organizations_request_spec.rb' - - 'modules/meb_api/spec/requests/meb_api/v0/education_benefits_spec.rb' - - 'modules/meb_api/spec/requests/meb_api/v0/forms_spec.rb' - - 'modules/mobile/spec/request/claims_and_appeals_overview_request_spec.rb' - - 'modules/mobile/spec/request/individual_appeal_request_spec.rb' - - 'modules/mobile/spec/request/individual_claim_request_spec.rb' - - 'modules/mobile/spec/request/payment_history_request_spec.rb' - - 'modules/mobile/spec/request/prescriptions_request_spec.rb' - - 'modules/mobile/spec/request/push_send_request_spec.rb' - - 'modules/mobile/spec/request/veterans_affairs_eligibility_request_spec.rb' - 'modules/va_forms/spec/lib/regex_helper_spec.rb' - - 'modules/vaos/spec/request/v2/appointments_request_spec.rb' - 'spec/controllers/v0/virtual_agent/virtual_agent_appeal_spec.rb' - 'spec/lib/evss/disability_compensation_form/data_translation_all_claim_spec.rb' - 'spec/lib/generators/module/module_generator_spec.rb' - 'spec/mailers/veteran_readiness_employment_mailer_spec.rb' - 'spec/models/facilities_query_spec.rb' - - 'spec/requests/decision_review_evidences_request_spec.rb' - - 'spec/requests/upload_supporting_evidence_request_spec.rb' - 'spec/sidekiq/vre/create_ch31_submissions_report_job_spec.rb' -# Offense count: 64 +# Offense count: 57 # Configuration parameters: AllowedPatterns. # AllowedPatterns: ^expect_, ^assert_ RSpec/NoExpectationExample: @@ -670,13 +618,10 @@ RSpec/NoExpectationExample: - 'modules/appeals_api/spec/docs/decision_reviews/notice_of_disagreements_spec.rb' - 'modules/appeals_api/spec/docs/decision_reviews/supplemental_claims_spec.rb' - 'modules/appeals_api/spec/support/doc_helpers.rb' - - 'modules/check_in/spec/request/v2/sessions_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/disability_compensation_request_spec.rb' - 'modules/claims_api/spec/sidekiq/poa_vbms_updater_spec.rb' - 'modules/va_forms/spec/requests/metadata_spec.rb' - 'spec/config/initializers/staccato_spec.rb' - 'spec/controllers/application_controller_spec.rb' - - 'spec/controllers/v0/profile/ch33_bank_accounts_controller_spec.rb' - 'spec/controllers/v1/sessions_controller_spec.rb' - 'spec/lib/central_mail/service_spec.rb' - 'spec/lib/common/convert_to_pdf_spec.rb' @@ -691,7 +636,6 @@ RSpec/NoExpectationExample: - 'spec/models/saved_claim/caregivers_assistance_claim_spec.rb' - 'spec/models/saved_claim/dependency_verification_claim_spec.rb' - 'spec/models/user_session_form_spec.rb' - - 'spec/requests/post911_gi_bill_status_request_spec.rb' - 'spec/requests/swagger_spec.rb' - 'spec/requests/v1/apidoc/apidoc_spec.rb' - 'spec/sidekiq/education_form/process10203_submissions_spec.rb' @@ -700,7 +644,7 @@ RSpec/NoExpectationExample: - 'spec/sidekiq/pager_duty/poll_maintenance_windows_spec.rb' - 'spec/sidekiq/vre/create_ch31_submissions_report_job_spec.rb' -# Offense count: 19 +# Offense count: 17 RSpec/PendingWithoutReason: Exclude: - 'modules/appeals_api/spec/controllers/application_controller_spec.rb' @@ -710,8 +654,6 @@ RSpec/PendingWithoutReason: - 'modules/claims_api/spec/lib/claims_api/v1/poa_pdf_constructor/individual_spec.rb' - 'modules/covid_vaccine/spec/sidekiq/covid_vaccine/scheduled_batch_job_spec.rb' - 'modules/vaos/spec/services/v1/fhir_service_spec.rb' - - 'modules/vba_documents/spec/request/v1/upload_complete_request_spec.rb' - - 'modules/vba_documents/spec/request/v2/uploads_request_spec.rb' - 'modules/vba_documents/spec/sidekiq/report_unsuccessful_submissions_spec.rb' - 'spec/lib/bb/generate_report_request_form_spec.rb' - 'spec/lib/bgs/vnp_relationships_spec.rb' @@ -720,14 +662,10 @@ RSpec/PendingWithoutReason: - 'spec/requests/breakers_integration_spec.rb' - 'spec/sidekiq/facilities/mental_health_reload_job_spec.rb' -# Offense count: 14 +# Offense count: 10 # This cop supports safe autocorrection (--autocorrect). RSpec/SortMetadata: Exclude: - - 'modules/claims_api/spec/requests/v2/veteran_identifier_request_spec.rb' - - 'modules/vba_documents/spec/request/v1/uploads_request_spec.rb' - - 'modules/vba_documents/spec/request/v2/uploads_request_spec.rb' - - 'modules/vba_documents/spec/request/v2/uploads_request_submission_spec.rb' - 'spec/lib/sftp_writer/factory_spec.rb' - 'spec/requests/authentication/standard_authentication_spec.rb' - 'spec/requests/swagger_spec.rb' @@ -738,7 +676,7 @@ RSpec/SortMetadata: - 'spec/sidekiq/education_form/process10203_submissions_spec.rb' - 'spec/sidekiq/education_form/send_school_certifying_officials_email_spec.rb' -# Offense count: 696 +# Offense count: 719 RSpec/StubbedMock: Enabled: false @@ -769,17 +707,13 @@ RSpec/SubjectDeclaration: - 'spec/sidekiq/pager_duty/cache_global_downtime_spec.rb' - 'spec/uploaders/form1010cg/poa_uploader_spec.rb' -# Offense count: 106 +# Offense count: 91 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: constant, string RSpec/VerifiedDoubleReference: Exclude: - 'modules/appeals_api/spec/lib/health_checker_spec.rb' - - 'modules/appeals_api/spec/requests/v1/notice_of_disagreements_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/higher_level_reviews_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/notice_of_disagreements_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/supplemental_claims_controller_spec.rb' - 'modules/appeals_api/spec/services/appeals_api/central_mail_updater_spec.rb' - 'modules/appeals_api/spec/sidekiq/appeals_api/daily_error_report_spec.rb' - 'modules/appeals_api/spec/sidekiq/appeals_api/monthly_stats_report_spec.rb' @@ -794,14 +728,10 @@ RSpec/VerifiedDoubleReference: - 'modules/appeals_api/spec/sidekiq/supplemental_claim_upload_status_batch_spec.rb' - 'modules/appeals_api/spec/sidekiq/supplemental_claim_upload_status_updater_spec.rb' - 'modules/appeals_api/spec/support/shared_examples_for_monitored_worker.rb' - - 'modules/claims_api/spec/requests/v1/claims_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/disability_compensation_request_spec.rb' - 'modules/claims_api/spec/sidekiq/claim_establisher_spec.rb' - 'modules/claims_api/spec/sidekiq/claim_uploader_spec.rb' - 'modules/claims_api/spec/sidekiq/poa_vbms_updater_spec.rb' - 'modules/vba_documents/spec/models/upload_submission_spec.rb' - - 'modules/vba_documents/spec/request/v1/uploads_request_spec.rb' - - 'modules/vba_documents/spec/request/v2/uploads_request_spec.rb' - 'modules/vba_documents/spec/sidekiq/upload_processor_spec.rb' - 'modules/vba_documents/spec/sidekiq/upload_status_batch_spec.rb' - 'modules/vba_documents/spec/sidekiq/upload_status_updater_spec.rb' @@ -836,52 +766,13 @@ RSpec/VerifiedDoubleReference: - 'spec/sidekiq/webhooks/callback_url_job_spec.rb' - 'spec/support/poa_stub.rb' -# Offense count: 623 +# Offense count: 87 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: ResponseMethods. # ResponseMethods: response, last_response RSpecRails/HaveHttpStatus: Exclude: - 'modules/appeals_api/spec/controllers/application_controller_spec.rb' - - 'modules/appeals_api/spec/requests/higher_level_reviews/v0/higher_level_reviews_controller_spec.rb' - - 'modules/appeals_api/spec/requests/legacy_appeals/v0/legacy_appeals_controller_spec.rb' - - 'modules/appeals_api/spec/requests/notice_of_disagreements/v0/notice_of_disagreements_controller_spec.rb' - - 'modules/appeals_api/spec/requests/schemas/shared_schemas_controller_spec.rb' - - 'modules/appeals_api/spec/requests/supplemental_claims/v0/supplemental_claims_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v1/notice_of_disagreements/evidence_submissions_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v1/notice_of_disagreements_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/higher_level_reviews_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/notice_of_disagreements/evidence_submissions_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/notice_of_disagreements_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/supplemental_claims/evidence_submission_controller_spec.rb' - - 'modules/appeals_api/spec/requests/v2/supplemental_claims_controller_spec.rb' - - 'modules/check_in/spec/request/patient_check_ins_request_spec.rb' - - 'modules/check_in/spec/request/v0/travel_claims_request_spec.rb' - - 'modules/check_in/spec/request/v1/patient_check_ins_request_spec.rb' - - 'modules/check_in/spec/request/v1/sessions_request_spec.rb' - - 'modules/check_in/spec/request/v2/apidocs_request_spec.rb' - - 'modules/check_in/spec/request/v2/demographics_request_spec.rb' - - 'modules/check_in/spec/request/v2/patient_check_ins_request_spec.rb' - - 'modules/check_in/spec/request/v2/pre_check_ins_request_spec.rb' - - 'modules/check_in/spec/request/v2/sessions_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/claims_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/disability_compensation_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/intent_to_file_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/power_of_attorney_request_spec.rb' - - 'modules/claims_api/spec/requests/v2/veteran_identifier_request_spec.rb' - - 'modules/claims_api/spec/requests/v2/veterans/claims_request_spec.rb' - - 'modules/claims_api/spec/requests/v2/veterans/evidence_waiver_request_spec.rb' - - 'modules/claims_api/spec/requests/v2/veterans/intent_to_files_request_spec.rb' - - 'modules/claims_api/spec/requests/v2/veterans/power_of_attorney_request_spec.rb' - - 'modules/debts_api/spec/request/debts_api/v0/financial_status_reports_controller_spec.rb' - - 'modules/dhp_connected_devices/spec/controllers/dhp_connected_devices/veteran_device_record_controller_spec.rb' - - 'modules/mobile/spec/request/appointments_cancel_request_spec.rb' - - 'modules/mobile/spec/request/claims_document_upload_spec.rb' - - 'modules/test_user_dashboard/spec/requests/tud_accounts_request_spec.rb' - - 'modules/test_user_dashboard/spec/requests/tud_github_oauth_proxy_spec.rb' - - 'modules/vaos/spec/request/v2/appointments_request_spec.rb' - - 'modules/vba_documents/spec/request/v1/uploads_request_spec.rb' - - 'modules/vba_documents/spec/request/v2/uploads_request_spec.rb' - 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/v0/benefits_reference_data_controller_spec.rb' - 'spec/controllers/v0/caregivers_assistance_claims_controller_spec.rb' @@ -892,39 +783,23 @@ RSpecRails/HaveHttpStatus: - 'spec/controllers/v0/gi_bill_feedbacks_controller_spec.rb' - 'spec/controllers/v0/onsite_notifications_controller_spec.rb' - 'spec/controllers/v0/profile/address_validation_controller_spec.rb' - - 'spec/controllers/v0/profile/ch33_bank_accounts_controller_spec.rb' - 'spec/controllers/v0/profile/communication_preferences_controller_spec.rb' - 'spec/controllers/v0/profile/payment_history_controller_spec.rb' - 'spec/controllers/v0/profile/valid_va_file_numbers_controller_spec.rb' - 'spec/controllers/v0/veteran_readiness_employment_claims_controller_spec.rb' - 'spec/lib/vetext/service_spec.rb' - 'spec/middleware/rack/attack_spec.rb' - - 'spec/requests/burial_claims_spec.rb' - - 'spec/requests/claim_documents_spec.rb' - 'spec/requests/csrf_request_spec.rb' - - 'spec/requests/documents_spec.rb' - - 'spec/requests/education_benefits_claims_request_spec.rb' - - 'spec/requests/evss_claims_spec.rb' - - 'spec/requests/form1095_b_spec.rb' - - 'spec/requests/health_care_applications_request_spec.rb' - - 'spec/requests/in_progress_forms_request_spec.rb' - - 'spec/requests/mpi_users_request_spec.rb' - - 'spec/requests/pension_claims_controller_spec.rb' - - 'spec/requests/ppiu_request_spec.rb' - - 'spec/requests/service_history_request_spec.rb' - - 'spec/requests/user_request_spec.rb' - - 'spec/requests/v0/in_progress_forms/5655_request_spec.rb' - - 'spec/requests/v0/lgy_coe_request_spec.rb' - 'spec/support/controller_spec_helper.rb' - 'spec/support/shared_examples_for_mhv.rb' -# Offense count: 304 +# Offense count: 473 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Inferences. RSpecRails/InferredSpecType: Enabled: false -# Offense count: 15 +# Offense count: 14 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: ExpectedOrder, Include. # ExpectedOrder: index, show, new, edit, create, update, destroy @@ -935,7 +810,6 @@ Rails/ActionOrder: - 'app/controllers/v0/dependents_applications_controller.rb' - 'app/controllers/v0/gi_bill_feedbacks_controller.rb' - 'app/controllers/v0/health_care_applications_controller.rb' - - 'app/controllers/v0/notice_of_disagreements_controller.rb' - 'app/controllers/v0/onsite_notifications_controller.rb' - 'modules/appeals_api/app/controllers/appeals_api/v1/decision_reviews/notice_of_disagreements/evidence_submissions_controller.rb' - 'modules/appeals_api/app/controllers/appeals_api/v1/decision_reviews/notice_of_disagreements_controller.rb' @@ -973,15 +847,13 @@ Rails/DeprecatedActiveModelErrorsMethods: Exclude: - 'modules/mobile/lib/mobile/v0/exceptions/validation_errors.rb' -# Offense count: 54 +# Offense count: 36 # This cop supports safe autocorrection (--autocorrect). Rails/DurationArithmetic: Exclude: - 'app/serializers/dependents_verifications_serializer.rb' - 'modules/claims_api/spec/models/auto_establish_claim_spec.rb' - 'modules/claims_api/spec/models/veteran/service/user_spec.rb' - - 'modules/claims_api/spec/requests/v1/disability_compensation_request_spec.rb' - - 'modules/covid_vaccine/spec/request/covid_vaccine/v0/registration_request_spec.rb' - 'modules/vaos/spec/services/user_service_spec.rb' - 'modules/vba_documents/app/sidekiq/vba_documents/upload_scanner.rb' - 'modules/vba_documents/spec/lib/object_store_spec.rb' @@ -1030,7 +902,7 @@ Rails/IgnoredColumnsAssignment: Exclude: - 'modules/test_user_dashboard/app/models/test_user_dashboard/tud_account.rb' -# Offense count: 25 +# Offense count: 20 # This cop supports unsafe autocorrection (--autocorrect-all). Rails/Pluck: Exclude: @@ -1042,11 +914,8 @@ Rails/Pluck: - 'app/sidekiq/facilities/mental_health_reload_job.rb' - 'lib/decision_review/utilities/pdf_validation/service.rb' - 'lib/webhooks/utilities.rb' - - 'modules/appeals_api/spec/requests/api_docs_request_spec.rb' - - 'modules/appeals_api/spec/requests/v1/docs_controller_spec.rb' - 'modules/health_quest/app/services/health_quest/questionnaire_manager/questionnaire_formatter.rb' - 'modules/mobile/lib/scripts/appointments_list_validation.rb' - - 'modules/mobile/spec/request/v1/immunizations_request_spec.rb' - 'rakelib/decision_review_repl.rb' - 'spec/controllers/v0/onsite_notifications_controller_spec.rb' - 'spec/lib/lighthouse/veterans_health/integration/client_spec.rb' @@ -1066,7 +935,7 @@ Rails/RedundantPresenceValidationOnBelongsTo: - 'modules/claims_api/app/models/claims_api/supporting_document.rb' - 'modules/dhp_connected_devices/app/models/veteran_device_record.rb' -# Offense count: 160 +# Offense count: 76 # This cop supports unsafe autocorrection (--autocorrect-all). Rails/RootPathnameMethods: Exclude: @@ -1075,16 +944,6 @@ Rails/RootPathnameMethods: - 'lib/decision_review/schemas.rb' - 'modules/appeals_api/app/models/appeals_api/notice_of_disagreement.rb' - 'modules/appeals_api/spec/support/schema_helpers.rb' - - 'modules/claims_api/spec/requests/v1/disability_compensation_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/intent_to_file_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/power_of_attorney_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/rswag_claims_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/rswag_disability_compensation_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/rswag_intent_to_file_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/rswag_power_of_attorney_request_spec.rb' - - 'modules/claims_api/spec/requests/v2/rswag_veteran_identifier_request_spec.rb' - - 'modules/claims_api/spec/requests/v2/veterans/rswag_claims_request_spec.rb' - - 'modules/claims_api/spec/requests/v2/veterans/rswag_evidence_waiver_spec.rb' - 'modules/claims_api/spec/requests/v2/veterans/rswag_intent_to_file_request_spec.rb' - 'modules/claims_api/spec/requests/v2/veterans/rswag_power_of_attorney_spec.rb' - 'modules/claims_api/spec/support/swagger_shared_components/v1.rb' @@ -1102,9 +961,7 @@ Rails/RootPathnameMethods: - 'spec/lib/decision_review/service_spec.rb' - 'spec/lib/hca/enrollment_system_spec.rb' - 'spec/models/form_profile_spec.rb' - - 'spec/requests/health_care_applications_request_spec.rb' - 'spec/requests/swagger_spec.rb' - - 'spec/requests/v0/notice_of_disagreements_controller_request_spec.rb' # Offense count: 2 # Configuration parameters: ForbiddenMethods, AllowedMethods. @@ -1132,6 +989,7 @@ Rails/UniqueValidationWithoutIndex: # Offense count: 3 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowedReceivers. +# AllowedReceivers: params Style/CollectionCompact: Exclude: - 'lib/saml/user_attributes/ssoe.rb' @@ -1166,7 +1024,7 @@ Style/FileRead: - 'modules/vba_documents/spec/sidekiq/upload_processor_spec.rb' - 'spec/lib/hca/service_spec.rb' -# Offense count: 12 +# Offense count: 11 # This cop supports safe autocorrection (--autocorrect). Style/FileWrite: Exclude: @@ -1219,7 +1077,7 @@ Style/NegatedIfElseCondition: - 'modules/dhp_connected_devices/app/serializers/device_serializer.rb' - 'modules/vaos/app/controllers/vaos/v2/appointments_controller.rb' -# Offense count: 453 +# Offense count: 482 Style/OpenStructUse: Enabled: false @@ -1235,7 +1093,7 @@ Style/OptionalBooleanParameter: - 'lib/pdf_fill/hash_converter.rb' - 'spec/support/authenticated_session_helper.rb' -# Offense count: 296 +# Offense count: 271 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: same_as_string_literals, single_quotes, double_quotes @@ -1249,7 +1107,6 @@ Style/QuotedSymbols: - 'modules/appeals_api/spec/models/supplemental_claim_spec.rb' - 'modules/appeals_api/spec/support/rswag_config.rb' - 'modules/claims_api/lib/claims_api/evidence_waiver_pdf/pdf.rb' - - 'modules/claims_api/lib/claims_api/v2/mock_documents_service.rb' - 'modules/dhp_connected_devices/app/services/token_storage_service.rb' - 'modules/dhp_connected_devices/spec/lib/fitbit_client_spec.rb' - 'modules/meb_api/lib/dgi/enrollment/service.rb' @@ -1278,14 +1135,13 @@ Style/RedundantArgument: - 'modules/appeals_api/spec/support/pdf_matcher.rb' - 'modules/mobile/app/models/mobile/v0/adapters/vaos_v2_appointment.rb' -# Offense count: 144 +# Offense count: 100 # This cop supports safe autocorrection (--autocorrect). Style/RedundantConstantBase: Exclude: - 'app/models/iam_user.rb' - 'app/models/iam_user_identity.rb' - 'config/environments/production.rb' - - 'modules/check_in/spec/request/v2/sessions_request_spec.rb' - 'modules/check_in/spec/services/v2/chip/service_spec.rb' - 'modules/check_in/spec/services/v2/lorota/service_spec.rb' - 'modules/claims_api/spec/factories/auto_established_claims.rb' @@ -1298,15 +1154,9 @@ Style/RedundantConstantBase: - 'modules/claims_api/spec/models/auto_establish_claim_spec.rb' - 'modules/claims_api/spec/models/power_of_attorney_spec.rb' - 'modules/claims_api/spec/models/supporting_document_spec.rb' - - 'modules/claims_api/spec/requests/v1/disability_compensation_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/power_of_attorney_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/rswag_disability_compensation_request_spec.rb' - - 'modules/claims_api/spec/requests/v1/rswag_power_of_attorney_request_spec.rb' - 'modules/claims_api/spec/sidekiq/claim_uploader_spec.rb' - 'modules/claims_api/spec/sidekiq/poa_vbms_sidekiq_spec.rb' - 'modules/meb_api/spec/dgi/status/service_spec.rb' - - 'modules/mobile/spec/request/claims_document_upload_spec.rb' - - 'modules/mobile/spec/request/prescriptions_request_spec.rb' - 'modules/test_user_dashboard/spec/services/create_test_user_account_spec.rb' - 'modules/vaos/spec/services/v1/fhir_service_spec.rb' - 'rakelib/test_user_account.rake' @@ -1318,9 +1168,6 @@ Style/RedundantConstantBase: - 'spec/lib/evss/documents_service_spec.rb' - 'spec/lib/hca/service_spec.rb' - 'spec/lib/sftp_writer/factory_spec.rb' - - 'spec/requests/documents_spec.rb' - - 'spec/requests/id_card_attributes_request_spec.rb' - - 'spec/requests/preneeds/burial_forms_request_spec.rb' - 'spec/requests/swagger_spec.rb' - 'spec/serializers/evss_claim_detail_serializer_spec.rb' - 'spec/sidekiq/education_form/create_daily_spool_files_spec.rb' @@ -1344,11 +1191,10 @@ Style/RedundantSelfAssignmentBranch: - 'modules/my_health/app/controllers/my_health/v1/prescriptions_controller.rb' - 'spec/support/authenticated_session_helper.rb' -# Offense count: 26 +# Offense count: 18 # This cop supports safe autocorrection (--autocorrect). Style/RedundantStringEscape: Exclude: - - 'app/swagger/swagger/requests/appeals/appeals.rb' - 'app/swagger/swagger/schemas/sign_in.rb' - 'app/swagger/swagger/v1/requests/appeals/appeals.rb' - 'modules/claims_api/spec/models/auto_establish_claim_spec.rb'