diff --git a/app/controllers/v0/in_progress_forms_controller.rb b/app/controllers/v0/in_progress_forms_controller.rb index 6b4ad68b2cc..5782124c408 100644 --- a/app/controllers/v0/in_progress_forms_controller.rb +++ b/app/controllers/v0/in_progress_forms_controller.rb @@ -28,7 +28,8 @@ def update if Flipper.enabled?(:intent_to_file_lighthouse_enabled, @current_user) && form.id_previously_changed? && Lighthouse::CreateIntentToFileJob::ITF_FORMS.include?(form.form_id) - Lighthouse::CreateIntentToFileJob.perform_async(form.form_id, form.created_at, @current_user.icn, @current_user.participant_id) + Lighthouse::CreateIntentToFileJob.perform_async(form.form_id, form.created_at, @current_user.icn, + @current_user.participant_id) end render json: InProgressFormSerializer.new(form) diff --git a/app/sidekiq/lighthouse/create_intent_to_file_job.rb b/app/sidekiq/lighthouse/create_intent_to_file_job.rb index df571c43718..ac0de31046f 100644 --- a/app/sidekiq/lighthouse/create_intent_to_file_job.rb +++ b/app/sidekiq/lighthouse/create_intent_to_file_job.rb @@ -24,7 +24,7 @@ class UserAccountNotFoundError < StandardError; end # exhausted attempts will be logged in intent_to_file_queue_exhaustions table sidekiq_options retry: 14, queue: 'low' sidekiq_retries_exhausted do |msg, error| - in_progress_form_id, veteran_icn, participant_id = msg['args'] + in_progress_form_id, veteran_icn = msg['args'] in_progress_form = InProgressForm.find(in_progress_form_id) itf_log_monitor = BenefitsClaims::IntentToFile::Monitor.new form_type = in_progress_form.form_id @@ -61,7 +61,7 @@ def perform(in_progress_form_id, veteran_icn, participant_id) @itf_log_monitor.track_create_itf_begun(@itf_type, @form_start_date, @user_account&.id) @service.create_intent_to_file(@itf_type, '') @itf_log_monitor.track_create_itf_success(@itf_type, @form_start_date, @user_account&.id) - rescue MissingICNError, MissingParticipantIDError => e + rescue MissingICNError, MissingParticipantIDError if veteran_icn.blank? @itf_log_monitor.track_missing_user_icn(@in_progress_form) elsif participant_id.blank? diff --git a/spec/sidekiq/lighthouse/create_intent_to_file_job_spec.rb b/spec/sidekiq/lighthouse/create_intent_to_file_job_spec.rb index 2346fa94521..901bc6927f7 100644 --- a/spec/sidekiq/lighthouse/create_intent_to_file_job_spec.rb +++ b/spec/sidekiq/lighthouse/create_intent_to_file_job_spec.rb @@ -8,7 +8,7 @@ let(:user) { create(:user) } let!(:user_verification) { create(:idme_user_verification, idme_uuid: user.idme_uuid) } let(:user_account) { create(:user_account, icn: user.icn, user_verifications: [user_verification]) } - let(:pension_ipf) { create(:in_progress_527_form, user_account: user_account) } + let(:pension_ipf) { create(:in_progress_527_form, user_account:) } let(:service) { double('service') } let(:monitor) { double('monitor') }