From 1dc3ecdf2744b59d04d1b5bebdb94070b8bd1e72 Mon Sep 17 00:00:00 2001 From: fatmakhan0395 <145523589+fatmakhan0395@users.noreply.github.com> Date: Mon, 26 Aug 2024 07:16:20 -0700 Subject: [PATCH] vebt-416, vebt-417, and vebt-419: links and heading updates to sco page (#31546) * updated headings for sco page and added download icons to pds * updated cypress test * updated cypress test --- .../SchoolCertifyingOfficialHandbook.jsx | 4 +- .../HubRail/shared/liSpanAndVaLink.jsx | 4 +- .../HubRail/shared/mainContentSubSection.jsx | 4 +- .../MainContent/Update/OtherResources.jsx | 22 ++-- .../MainContent/Update/UploadFileToVa.jsx | 16 ++- src/applications/sco/sass/sco.scss | 4 + .../sco/tests/accessibility.cypress.spec.js | 101 ++++-------------- 7 files changed, 60 insertions(+), 95 deletions(-) diff --git a/src/applications/sco/components/HubRail/SchoolCertifyingOfficialHandbook.jsx b/src/applications/sco/components/HubRail/SchoolCertifyingOfficialHandbook.jsx index 8dde070d8f61..8b709b1e662d 100644 --- a/src/applications/sco/components/HubRail/SchoolCertifyingOfficialHandbook.jsx +++ b/src/applications/sco/components/HubRail/SchoolCertifyingOfficialHandbook.jsx @@ -8,12 +8,12 @@ const SchoolCertifyingOfficialHandbook = () => {
Education Sco
-

+

-

+

via the VA Education Platform Portal

diff --git a/src/applications/sco/components/HubRail/shared/liSpanAndVaLink.jsx b/src/applications/sco/components/HubRail/shared/liSpanAndVaLink.jsx index c90af32698a8..300737a724a4 100644 --- a/src/applications/sco/components/HubRail/shared/liSpanAndVaLink.jsx +++ b/src/applications/sco/components/HubRail/shared/liSpanAndVaLink.jsx @@ -1,9 +1,9 @@ import React from 'react'; import PropTypes from 'prop-types'; -const LiSpanAndVaLink = ({ href, hrefText }) => ( +const LiSpanAndVaLink = ({ href, hrefText, download }) => (
  • - +
    • ); diff --git a/src/applications/sco/components/HubRail/shared/mainContentSubSection.jsx b/src/applications/sco/components/HubRail/shared/mainContentSubSection.jsx index 72ecf7eed14f..3f32cc27b370 100644 --- a/src/applications/sco/components/HubRail/shared/mainContentSubSection.jsx +++ b/src/applications/sco/components/HubRail/shared/mainContentSubSection.jsx @@ -5,9 +5,9 @@ const MainContentSubSection = ({ id, header, children }) => { return (
    -

    +

    {header} -

    +
    diff --git a/src/applications/sco/components/MainContent/Update/OtherResources.jsx b/src/applications/sco/components/MainContent/Update/OtherResources.jsx index 99a8f2b90bd8..de8cc68b8610 100644 --- a/src/applications/sco/components/MainContent/Update/OtherResources.jsx +++ b/src/applications/sco/components/MainContent/Update/OtherResources.jsx @@ -13,6 +13,7 @@ const OtherResources = () => { @@ -39,19 +40,23 @@ const OtherResources = () => { Quick Start Guides @@ -62,13 +67,15 @@ const OtherResources = () => { href="https://benefits.va.gov/GIBILL/enrollment-manager/enrollment-manager-system-updates.asp" /> @@ -89,6 +96,7 @@ const OtherResources = () => { @@ -103,7 +111,8 @@ const OtherResources = () => { href="https://authentication.tungsten-network.com/login" /> { diff --git a/src/applications/sco/components/MainContent/Update/UploadFileToVa.jsx b/src/applications/sco/components/MainContent/Update/UploadFileToVa.jsx index 6ff2843abd68..269d2c32a913 100644 --- a/src/applications/sco/components/MainContent/Update/UploadFileToVa.jsx +++ b/src/applications/sco/components/MainContent/Update/UploadFileToVa.jsx @@ -18,29 +18,35 @@ const UploadFileToVa = () => { Accepted forms
    diff --git a/src/applications/sco/sass/sco.scss b/src/applications/sco/sass/sco.scss index 008f7e93ce29..cc14c1b12c22 100644 --- a/src/applications/sco/sass/sco.scss +++ b/src/applications/sco/sass/sco.scss @@ -1 +1,5 @@ @import "~@department-of-veterans-affairs/formation/sass/shared-variables"; +.heading{ + font-size: 1.0625rem; + margin-top: 0; +} diff --git a/src/applications/sco/tests/accessibility.cypress.spec.js b/src/applications/sco/tests/accessibility.cypress.spec.js index 2283ea3180a0..59be21627413 100644 --- a/src/applications/sco/tests/accessibility.cypress.spec.js +++ b/src/applications/sco/tests/accessibility.cypress.spec.js @@ -16,39 +16,30 @@ describe('Accessibility', () => { cy.realPress('Tab'); cy.get('va-on-this-page').focused(); cy.focused().should('contain.text', 'Handbooks'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); + cy.repeatKey('Tab', 4); cy.focused().should('contain.text', 'Other resources for schools'); // Tab to 'Handbooks' links - cy.realPress('Tab'); - cy.focused().should('contain.text', 'School Certifying Official Handbook'); - cy.realPress('Tab'); + cy.realPress('Tab'); cy.focused().should( 'contain.text', - 'VR&E School Certifying Official Handbook', + 'Understanding Veteran education benefits', ); - // Tab to 'Trainings and webinars' links - cy.realPress('Tab'); + cy.repeatKey('Tab', 2); + // Employer’s Certification Handbook On-The-Job Training & Apprenticeship Programs + cy.focused().should( + 'contain.text', + 'Employer’s Certification Handbook On-The-Job Training & Apprenticeship Programs', + ); + + cy.repeatKey('Tab', 2); cy.focused().should('contain.text', 'Training Requirements'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); + cy.repeatKey('Tab', 4); cy.focused().should('contain.text', 'GovDelivery Message Archive'); // Tab to 'Program approval information' links cy.realPress('Tab'); cy.focused().should('contain.text', 'WEAMS Institution Search'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); + cy.repeatKey('Tab', 8); cy.focused().should( 'contain.text', 'State Approving Agency Contact Information', @@ -70,15 +61,12 @@ describe('Accessibility', () => { 'contain.text', 'Designation of Certifying Official(s) - VA Form 22-8794 (PDF, 3 pages)', ); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); + cy.repeatKey('Tab', 4); cy.focused().should( 'contain.text', 'Conflicting Interests Certification for Proprietary Schools - VA Form 22-1919 (PDF, 1 page)', ); - // Tab to 'Other resources for schools' section + // // Tab to 'Other resources for schools' section cy.realPress('Tab'); cy.focused().should('contain.text', 'Expand all +'); cy.realPress('Enter'); @@ -87,24 +75,14 @@ describe('Accessibility', () => { cy.focused().should('contain.text', 'Enrollment Manager'); cy.realPress('Tab'); cy.focused().should('contain.text', 'Launch VA Education Platform Portal'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); + cy.repeatKey('Tab', 8); cy.focused().should( 'contain.text', 'VA Paper Based Forms to Enrollment Manager Crosswalk (PPTX, 124 pages)', ); cy.realPress('Tab'); cy.focused().should('contain.text', 'Payment and debt'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); + cy.repeatKey('Tab', 4); cy.focused().should( 'contain.text', 'Veteran Readiness and Employment (VR&E) Chapter 31', @@ -114,32 +92,13 @@ describe('Accessibility', () => { 'contain.text', 'VR&E School Certifying Official Handbook', ); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); + cy.repeatKey('Tab', 6); cy.focused().should('contain.text', 'How to apply for VR&E'); - cy.realPress('Tab'); - cy.realPress('Tab'); + cy.repeatKey('Tab', 2); cy.focused().should('contain.text', '85/15'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); + cy.repeatKey('Tab', 10); cy.focused().should('contain.text', 'About GI Bill Benefits'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); + cy.repeatKey('Tab', 5); // Should be focused on right panel now cy.focused().should('contain.text', 'Access Enrollment Manager'); cy.realPress('Tab'); @@ -147,24 +106,10 @@ describe('Accessibility', () => { // Tab to 'Ask questions' section cy.realPress('Tab'); cy.focused().should('contain.text', 'Ask questions'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); + cy.repeatKey('Tab', 11); // Tab to 'Connect with us' section - cy.realPress('Tab'); cy.focused().should('contain.text', 'Connect with us'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); - cy.realPress('Tab'); + cy.repeatKey('Tab', 5); cy.focused().should('contain.text', 'VBA on YouTube'); }); });