From ef20a02f81275d0ac49232b0a7117eefcf125373 Mon Sep 17 00:00:00 2001 From: Jeff Widman Date: Wed, 22 Mar 2023 12:18:08 -0700 Subject: [PATCH] Update pipenv_version_resolver.rb (#6837) Unfortunately, bumping to the latest version of `pipenv` is currently blocked on us dropping support for Python 3.6: * https://github.com/dependabot/dependabot-core/pull/6104#issuecomment-1397616478 So for now let's clarify the comment with a TODO... This whole bit of code may also get redone if we switch the interface we use: * https://github.com/dependabot/dependabot-core/issues/6836 But for now let's capture some notes until we can devote more time to this. --- .../python/update_checker/pipenv_version_resolver.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/python/lib/dependabot/python/update_checker/pipenv_version_resolver.rb b/python/lib/dependabot/python/update_checker/pipenv_version_resolver.rb index 51237451cce..0e6d8f14d96 100644 --- a/python/lib/dependabot/python/update_checker/pipenv_version_resolver.rb +++ b/python/lib/dependabot/python/update_checker/pipenv_version_resolver.rb @@ -239,8 +239,10 @@ def handle_pipenv_errors_resolving_original_reqs(error) raise DependencyFileNotResolvable, msg end - # NOTE: Pipenv masks the actualy error, see this issue for updates: + # NOTE: Pipenv masks the actual error, see this issue for updates: # https://github.com/pypa/pipenv/issues/2791 + # TODO: This may no longer be reproducible on latest pipenv, see linked issue, + # so investigate when we next bump to newer pipenv... handle_pipenv_installation_error(error.message) if error.message.match?(PIPENV_INSTALLATION_ERROR_REGEX) # Raise an unhandled error, as this could be a problem with