Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to leveraging pipenv's new pipenv upgrade command #6836

Closed
jeffwidman opened this issue Mar 14, 2023 · 2 comments · Fixed by #8312
Closed

Switch to leveraging pipenv's new pipenv upgrade command #6836

jeffwidman opened this issue Mar 14, 2023 · 2 comments · Fixed by #8312
Labels
EE Engineering Efficiency L: python:pipenv Python packages via pipenv T: tech-debt ⚙️

Comments

@jeffwidman
Copy link
Member

jeffwidman commented Mar 14, 2023 •
edited
Loading

I have another update for dependabot team though -- which is in the main branch of pipenv is a a new pipenv upgrade command that should be perfect for dependabot's use case of upgrading the Pipfile/Pipfile.lock (doesn't require package install) -- and doesn't affect the whole set of lock file dependencies.

Since --selective-upgrade and --keep-outdated are deprecated for removal, it would be useful to try updating dependabot to use this new command (it will be in the next release, maybe in a week but you can try it out from the main branch today).

If you are experiencing issues related to the upgrade path, feel free to open new issue reports and we will prioritize looking into them. Thank you!

Originally posted by @matteius in pypa/pipenv#2791 (comment)
@jeffwidman jeffwidman added T: tech-debt ⚙️ L: python:pipenv Python packages via pipenv labels Mar 14, 2023
@jeffwidman
Copy link
Member Author

Unfortunately, bumping to the latest version of pipenv is currently blocked on us dropping support for Python 3.6:

This was referenced Mar 14, 2023
Merged
Closed
@jeffwidman
Copy link
Member Author

Upstream PR adding the feature:

Many thanks @matteius for adding this to help out the Dependabot / package updater bot use case. 😍

jeffwidman added a commit that referenced this issue Mar 22, 2023
@jeffwidman
Clarify TODO
cf1f616 
Unfortunately, bumping to the latest version of `pipenv` is currently blocked on us dropping support for Python 3.6:
* #6104 (comment)

So for now let's clarify the comment with a TODO...

This whole bit of code may also get redone if we switch the interface we use:
* #6836

But for now let's capture some notes until we can devote more time to this.
jeffwidman added a commit that referenced this issue Mar 22, 2023
@jeffwidman
Clarify TODO
66c7bbd 
Unfortunately, bumping to the latest version of `pipenv` is currently blocked on us dropping support for Python 3.6:
* #6104 (comment)

So for now let's clarify the comment with a TODO...

This whole bit of code may also get redone if we switch the interface we use:
* #6836

But for now let's capture some notes until we can devote more time to this.
jeffwidman added a commit that referenced this issue Mar 22, 2023
@jeffwidman
Clarify TODO
d477e5a 
Unfortunately, bumping to the latest version of `pipenv` is currently blocked on us dropping support for Python 3.6:
* #6104 (comment)

So for now let's clarify the comment with a TODO...

This whole bit of code may also get redone if we switch the interface we use:
* #6836

But for now let's capture some notes until we can devote more time to this.
jeffwidman added a commit that referenced this issue Mar 22, 2023
@jeffwidman
Update pipenv_version_resolver.rb (#6837)
ef20a02 
Unfortunately, bumping to the latest version of `pipenv` is currently blocked on us dropping support for Python 3.6:
* #6104 (comment)

So for now let's clarify the comment with a TODO... 

This whole bit of code may also get redone if we switch the interface we use:
* #6836

But for now let's capture some notes until we can devote more time to this.
@abdulapopoola abdulapopoola added the EE Engineering Efficiency label Mar 30, 2023
@jeffwidman jeffwidman mentioned this issue Jul 25, 2023
Open
3 tasks
This was referenced Aug 3, 2023
Closed
Closed
Merged
@deivid-rodriguez deivid-rodriguez mentioned this issue Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
EE Engineering Efficiency L: python:pipenv Python packages via pipenv T: tech-debt ⚙️
Projects
Dependabot
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace pipenv lock with pipenv upgrade dependabot/dependabot-core
2 participants
@jeffwidman @abdulapopoola