Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme example contains invalid workflow syntax #560

Closed
CloudNStoyan opened this issue Oct 10, 2024 · 1 comment
Closed

Readme example contains invalid workflow syntax #560

CloudNStoyan opened this issue Oct 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@CloudNStoyan
Copy link
Contributor

The if conditional inside the README's example should be before steps and not jobs

fetch-metadata/README.md

Lines 19 to 37 in b0d0393

```yaml
-- .github/workflows/dependabot-prs.yml
name: Dependabot Pull Request
on: pull_request
if: github.event.pull_request.user.login == 'dependabot[bot]' && github.repository == 'owner/my_repo'
jobs:
build:
permissions:
pull-requests: read
runs-on: ubuntu-latest
steps:
- name: Fetch Dependabot metadata
id: dependabot-metadata
uses: dependabot/fetch-metadata@v2
with:
alert-lookup: true
compat-lookup: true
github-token: "${{ secrets.PAT_TOKEN }}"
```

Currently this is not valid workflow syntax as far as I can tell :)

@CloudNStoyan CloudNStoyan added the bug Something isn't working label Oct 10, 2024
@Nishnha Nishnha closed this as completed Oct 23, 2024
@Nishnha
Copy link
Member

Nishnha commented Oct 23, 2024

Fixed by fix readme action example #563. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants