Page type incompatibility when updating @playwright/test

[ritchieanesco]

Product

playwright

Product Version

4.9.1

Latest Version

• I have tested the issue with the latest version of the product

Issue Description

Expectation

No type errors when updating @playwright/tests package

Actual

Page type error occurs when running tsc --noEmit after updating @playwright/tests package

How to Reproduce

1. Use Page type from @playwright.tests package in your tests.
2. Use a version of @axe-core/playwright that uses a older version of @playwright/tests.
3. Run tsc --noEmit

[Zidious]

Hey @ritchieanesco,

What version were you on and what version of @playwright/test caused the type break?

Thanks!

[DyHex]

@Zidious

Type 'import("C:/Users/....../Playwright/node_modules/.pnpm/playwright-core@1.46.0/node_modules/playwright-core/types/types").Page' is not assignable to type 'import("C:/Users/....../Playwright/node_modules/.pnpm/playwright-core@1.45.3/node_modules/playwright-core/types/types").Page'.ts(2322)
index.d.ts(5, 5): The expected type comes from property 'page' which is declared here on type 'AxePlaywrightParams'

Generally get this error everytime I upgrade playwright/test to a new version

[florestankorp]

Same here!

[evadecker]

I'm also encountering this issue.

"@axe-core/playwright": "^4.10.1"
"@playwright/test": "^1.49.0"
"typescript": "^5.7.2"

tests/accessibility.spec.ts:22:9 - error ts(2322): Type 'import("/opt/build/repo/node_modules/.pnpm/playwright-core@1.49.0/node_modules/playwright-core/types/types").Page' is not assignable to type 'import("/opt/build/repo/node_modules/.pnpm/playwright-core@1.48.2/node_modules/playwright-core/types/types").Page'.

The types returned by 'evaluateHandle(...)' are incompatible between these types.

[charlesanim]

bumping this. Encountered issue

[charlesanim]

bumping one more time. @Zidious

[rypete]

@Zidious We got this error going from @playwright/test 1.49.0 to 1.49.1 using @axe-core/playwright 4.10.1

[Zidious]

Hello folks,

Apologies for the delays. I am not able to reproduce this error, I am using: @axe-core/playwright version ^4.10.1
and @playwright/test version ^1.49.1. Using this example:

import { AxeBuilder } from "@axe-core/playwright";
import { chromium } from "@playwright/test";

(async () => {
  const browser = await chromium.launch({ headless: true });
  const context = await browser.newContext();
  const page = await context.newPage();
  await page.goto("https://dequeuniversity.com/demo/mars/");

  try {
    const results = await new AxeBuilder({ page }).analyze();
    console.log(results);
  } catch (e) {
    // do something with the error
  }

  await browser.close();
})();

Are you able to provide an example where this is reproducible and I'll be able to take a look?

[rypete]

Thanks for that @Zidious. That example does work for me in an a fresh project.

I've dug deeper into my troubled project and found we had an additional playwright dependency that was causing the issue. The dependency in question was @playwright/experimental-ct-react. It was still on 1.49.0 and updating it to 1.49.1 to match the main @playwright/test dependency resolved the issue. Im guessing that dependency is augmenting the Page type.

Anyone else experiencing this issue have a look for other playwright dependencies.