Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-required-attr should consider fallback values #4481

Open
WilcoFiers opened this issue May 28, 2024 · 1 comment
Open

aria-required-attr should consider fallback values #4481

WilcoFiers opened this issue May 28, 2024 · 1 comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule standards Issues in the ARIA standards objects (lib/standards) wai-aria
Milestone

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented May 28, 2024

In ARIA 1.2 the W3C removed all default values from properties that were set to be required. We updated axe-core accordingly, requiring attributes that had not been before. What we had missed is that after they did this, a table was added which re-introduced these default values as "fallback values" in a separate section of ARIA:

https://www.w3.org/TR/wai-aria-1.3/#document-handling_author-errors_states-properties

The example for which this came up was aria-level on role=heading. This should not fail axe-core. All major screen readers seem to report this as a level 2 heading:

<div role=heading>Hello world</div>

Passing that doesn't seem like an issue. I'm much more concerned about having axe-core pass things like checkboxes without aria-checked, or a combobox without aria-controls or aria-expanded. Those will need more discussion. Looking at how ACT has done this, it has a similar rule which requires these things to be failed. It doesn't require these to be mapped to WCAG though, so if we wanted to stay consistent with ACT perhaps the best thing to do is for us to make this a best practice rule instead.

@WilcoFiers WilcoFiers added this to the Axe-core 4.10 milestone May 28, 2024
@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule wai-aria standards Issues in the ARIA standards objects (lib/standards) labels May 28, 2024
@WilcoFiers
Copy link
Contributor Author

This change is going to impact our ACT implementation. We should do something in ACT to ensure they make the same change we make here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule standards Issues in the ARIA standards objects (lib/standards) wai-aria
Projects
None yet
Development

No branches or pull requests

1 participant