Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autocomplete-valid (SC 1.3.5) triggers error for autocomplete="text" #4492

Closed
1 task done
cstrobbe opened this issue Jun 5, 2024 · 2 comments · Fixed by #4500 · May be fixed by Stanislav1975/sitespeed.io#11, Stanislav1975/sitespeed.io#12 or organich/lighthouse#4
Closed
1 task done

autocomplete-valid (SC 1.3.5) triggers error for autocomplete="text" #4492

cstrobbe opened this issue Jun 5, 2024 · 2 comments · Fixed by #4500 · May be fixed by Stanislav1975/sitespeed.io#11, Stanislav1975/sitespeed.io#12 or organich/lighthouse#4
Assignees
@gaiety-deque
Labels
fix Bug fixes rules Issue or false result from an axe-core rule

Comments

@cstrobbe
Copy link

cstrobbe commented Jun 5, 2024

Product

axe Extension

Product Version

No response

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Expectation

autocomplete="text" is not flagged as a violation of SC 1.3.5.

Actual

Axe Devtools flags <input class="form-text" id="term" name="term" type="text" aria-required="false" autocomplete="text" placeholder="Zoek op titel, trefwoord" value=""> as a WCAG violation.

How to Reproduce

Create a page with something like <input class="form-text" id="term" name="term" type="text" aria-required="false" autocomplete="text" value=""> (basically a generic search field) or go to Zoek een tool. Run Axe Devtools and notice that it reports the following issue: autocomplete attribute must be used correctly.

Additional context

While "text" is not among the values listed in the HTML specificiation, the field does not collect information about the user, so SC 1.3.5 is not even applicable.
@cstrobbe cstrobbe added the ungroomed Ticket needs a maintainer to prioritize and label label Jun 5, 2024
@github-actions github-actions bot added the extension Axe Firefox or Chrome extension issues label Jun 5, 2024
@WilcoFiers
Copy link
Contributor

Thanks for reporting this @cstrobbe. I agree with you this doesn't fail WCAG. An autocomplete attribute that isn't needed doesn't need to be valid. We have a few other rules where we have harmless "common" HTML mistakes reported as needing review rather than as an issue. I think that's the way to go here. Looking into GitHub search it seems people do use autocomplete="text" from time to time.

@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule and removed extension Axe Firefox or Chrome extension issues ungroomed Ticket needs a maintainer to prioritize and label labels Jun 5, 2024
@gaiety-deque
Copy link
Contributor

gaiety-deque commented Jun 10, 2024 •
edited
Loading

Wilco suggested I add a list, that contains text for now. Bonus points if I add other common harmless but invalid values.

If autocomplete is any in this list, incomplete it.

@gaiety-deque gaiety-deque self-assigned this Jun 10, 2024
gaiety-deque added a commit that referenced this issue Jun 11, 2024
@gaiety-deque
fix(autocomplete-valid): incomplete for invalid but safe values
1515f72 
autocomplete="text" incompletes

Refs: #4492
@gaiety-deque gaiety-deque mentioned this issue Jun 11, 2024
Merged
@attest-team-ci attest-team-ci mentioned this issue Jul 29, 2024
Merged
WilcoFiers added a commit that referenced this issue Jul 29, 2024
@WilcoFiers
chore(release): v4.10.0 (#4545)
c49c8ea 
##
[4.10.0](v4.9.1...v4.10.0)
(2024-07-29)

### Features

- **new-rule:** summary elements must have an accessible name
([#4511](#4511))
([0d8a99e](0d8a99e)),
closes [#4510](#4510)

### Bug Fixes

- **all-rules:** fix flakey all-rules firefox test
([#4467](#4467))
([3f13aa1](3f13aa1))
- **aria-allowed-attr:** allow aria-multiline=false for element with
contenteditable
([#4537](#4537))
([f019068](f019068))
- **aria-allowed-attr:** allow aria-required=false when normally not
allowed ([#4532](#4532))
([2e242e1](2e242e1))
- **aria-prohibited-attr:** allow aria-label/ledby on decendants of
widget ([#4541](#4541))
([07c5d91](07c5d91))
- **aria-roledescription:** keep disabled with { runOnly: 'wcag2a' }
([#4526](#4526))
([5b4cb9d](5b4cb9d)),
closes [#4523](#4523)
- **autocomplete-valid:** incomplete for invalid but safe values
([#4500](#4500))
([e31a974](e31a974)),
closes [#4492](#4492)
- **build:** limit locales to valid files when using the --all-lang
option ([#4486](#4486))
([d3db593](d3db593)),
closes [#4485](#4485)
- colorio.js patch mocking CSS
([#4456](#4456))
([3ef9353](3ef9353)),
closes [#4400](#4400)
- correct typos in texts
([#4499](#4499))
([11fad59](11fad59))
- **landmark-unique:** follow spec, aside -> landmark
([#4469](#4469))
([e32f803](e32f803)),
closes [#4460](#4460)
- **required-attr:** allow aria-valuetext on slider instead of valuenow
([#4518](#4518))
([135898b](135898b)),
closes [#4515](#4515)

This PR was opened by a robot 🤖 🎉
@Stanislav1975 Stanislav1975 mentioned this issue Aug 19, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this issue Sep 9, 2024
Open
@organich organich mentioned this issue Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaiety-deque gaiety-deque

Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Milestone
No milestone
3 participants
@WilcoFiers @cstrobbe @gaiety-deque