Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorize pod row if pod is not ready because of failing readiness gates #1760

Open
hosh opened this issue Sep 17, 2022 · 1 comment · May be fixed by #2826
Open

Colorize pod row if pod is not ready because of failing readiness gates #1760

hosh opened this issue Sep 17, 2022 · 1 comment · May be fixed by #2826
Labels
enhancement New feature or request

Comments

@hosh
Copy link

hosh commented Sep 17, 2022




Is your feature request related to a problem? Please describe.
With a healthy pod with one or more false readiness gate, the pod is not included in the service endpoints. However, the current UI makes it look like everything is working.

Describe the solution you'd like
The row with one or more failed readiness gate in the pod view should be a different color, even when the containers are ready and pod status is "running".

Describe alternatives you've considered
I have tried to move the READINESS GATE column next to READY column, but that requires having everyone on my team also customize their view. It's difficult to pick out what the issue might be by parsing the numbers alone. At a glance, the k9s ux lets us quickly see what might be wrong because errors shows up as a different column

Additional context
We had not had to use readiness gates until now, so I can see why this is not really used much. Readiness Gates lets us immediately push an unready signal, so we can better control graceful termination. However, without making it visible as a different color, failures in readiness gates are not so easily surfaced up.

@hosh
Copy link
Author

hosh commented Sep 17, 2022

I saw in the rendering code a call to Happy(), and I wonder if that could be patched to include checks with the readiness gates. I'm not familiar with the code base or with Go, so I have not yet looked at how that function is implemented, or how easy it might be for me to submit a patch.

@derailed derailed added the enhancement New feature or request label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants