ahmed/DAPI-790/fix--markup-error-message

Author: ahmed-deriv

i18n/en/code.json

@@ -122,8 +122,8 @@
   "Enter a valid URL. (Example: https://www.[YourDomainName].com)": {
     "message": "Enter a valid URL. (Example: https://www.[YourDomainName].com)"
   },
-  "Your markup value must be equal to or above 0.00": {
-    "message": "Your markup value must be equal to or above 0.00"
+  "Your markup value must be equal to or above 0.00.": {
+    "message": "Your markup value must be equal to or above 0.00."
   },
   "Your markup value must be no more than 3.00.": {
     "message": "Your markup value must be no more than 3.00."
@@ -1109,5 +1109,8 @@
   "theme.unlistedContent.message": {
     "message": "This page is unlisted. Search engines will not index it, and only users having a direct link can access it.",
     "description": "The unlisted content banner message"
+  },
+  "Markup value is required and must be between 0.00 and 3.00.": {
+    "message": "Markup value is required and must be between 0.00 and 3.00."
   }
 }

src/features/dashboard/types.ts

@@ -61,11 +61,17 @@ const base_schema = {
     }),
   app_markup_percentage: yup
     .number()
-    .required()
+    .nullable()
+    .transform((value, originalValue) => (originalValue === '' ? null : value))
+    .required(
+      translate({
+        message: 'Markup value is required and must be between 0.00 and 3.00.',
+      }),
+    )
     .min(
       0,
       translate({
-        message: 'Your markup value must be equal to or above 0.00',
+        message: 'Your markup value must be equal to or above 0.00.',
       }),
     )
     .max(