Use normal CLI with parameters and options #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafshen
previously approved these changes
Jul 15, 2023
There was a problem hiding this comment.
looks great,
consider improving readme examples part as well:
- point to
target/management-cli-1.0.jarand nottarget/management-cli.jar(or fix the target) - an example for running something with command (and maybe also the help command)
- better explantation about the process of building and running (e.g. which folder to be on)
src/test/java/com/descope/sdk/auth/impl/AuthenticationServiceImplTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean the CLI example to actually do what it needs to do