-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with Altair v3 #1
Comments
Hey @imolorhe, Thanks for the heads up. I have a couple questions:
Thanks! |
@isaachvazquez The testing approach is the same as in the older version. Hosting the plugin locally and using something like |
Like I mentioned earlier, the plugin API is a bit different. When you define the plugin with an Ps: You can see the graphql explorer plugin using this new API, for reference: https://github.com/XKojiMedia/altair-graphql-plugin-graphql-explorer/blob/master/src/index.js |
@imolorhe Thanks for the reply. It was helpful to see your example plugin. That part makes sense. Can you help me understand what the "url" should be in this format? 2 questions:
Thanks! |
Using the graphql explorer plugin example again, I have an npm script that to create a local webserver for the plugin during development: https://github.com/XKojiMedia/altair-graphql-plugin-graphql-explorer/blob/master/package.json#L10 It hosts the plugin at http://localhost:8002, such that http://localhost:8002/manifest.json would return the manifest.json file and so on. To use this locally hosted version, I can add Ps: You don't need to use the Altair source code for this approach. You can use any Altair extensions you already have (chrome extension, firefox addon, desktop app, etc) 🙂 |
@imolorhe Thank you much! That's what I needed. It's working now. I'll update my plugin and publish shortly. |
Hello @isaachvazquez!
First, I want to thank you for building this plugin for Altair! This was one of the very few plugins publicly available for Altair, even though it was in beta. I wanted to let you know I appreciate the effort. 🙂
Unfortunately, the plugin architecture has been rewritten, to be more flexible, performant, maintainable, and easier to create. I rewrote it from the ground up, so plugins based on the previous plugin implementation are no longer compatible.
From Altair v3.0.0, older plugins would no longer show up in the plugin finder, or activate when installed.
Considering your plugin was already working with the previous plugin implementation, rewriting it to work with the new architecture should not be too difficult, and I'm willing to help any way I can.
Just a heads up, I am fairly comfortable with the current plugin implementation, and will be removing it from beta (finally 🥳 ), so your migration changes wouldn't go to waste 😄
Thanks again for your contributions!
Reference plugin creation guide: https://altair.sirmuel.design/docs/plugins/writing-plugin.html
The text was updated successfully, but these errors were encountered: