Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing quality in YT player changes the add-on's video quality settings #24

Open
muizzsiddique opened this issue May 25, 2023 · 3 comments

Comments

@muizzsiddique
Copy link

System

  • OS name: Windows
  • OS version: 10
  • Browser name: LibreWolf (Firefox fork)
  • Browser version: 112.0-1
  • Extension version: 2.0.0

Bug description

Changing the video resolution to a video permenantly sets that resolution to all other videos played afterwards. You have to manually change the resolution back in the YouTube player. For some reason, your add-on listens to any video quality changes and then sets it as the new default resolution.

Logs

No logs.

@dessant
Copy link
Owner

dessant commented Jul 17, 2023

This is by design, but we could add a new option to not sync option changes.

@muizzsiddique
Copy link
Author

From my perspective, setting a resolution in the extension is setting a global resolution, whereas setting a resolution in the player is a temporary resolution change. That's how I expected it to work.

@fallmake
Copy link

fallmake commented Oct 7, 2023

@dessant #23 addresses a different issue.

This issue here is for example:

  1. Go to extension options
  2. Change setting General > Video Quality to e.g. 480p
  3. Open any youtube video
  4. In the youtube player, change quality from 480p (configured in 2.) to 4k
  5. Problem: The General > Video Quality setting now also changed to 4k.
  6. Problem: Open any new videos on youtube --> The quality is 4k by default, but should be 480p.

Expected behavior: Set 480p in step 2 --> all videos opened on youtube will play at 480p. If a user decides that that's not enough, they can change to e.g. 1080p or 4k in the youtube player, but all videos should start with 480p still because that's what they configured in the extension settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants