Skip to content

Refactor specific methods in commandShell.py, xRules.py and htmlRendering.py. They have become monsters. #26

@deusExMac

Description

@deusExMac

These methods in particular require serious refactoring because they became monsters and have serious inconsistencies:

crawl() which is the main method that starts the crawling/extraction process.

downloadURL() in commandImpl class in the commandShell module (separating commandImpl from commandShell in already an issue, see previous postings). This has become a monster in terms of LOC.

render() method in htmlRendering. This method has: 1) obsolete parameters, 2) different ways of passing parameters (via instance variables and arguments) 3) is too large.

apply() method in xRules.py

Metadata

Metadata

Assignees

No one assigned

    Labels

    RefactorRefactor source codedesign issueWhen something is not designed properly; It was designed as implementation moved on.enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions