Skip to content

Commit 2af689b

Browse files
committed
v0.14.1: Adding Apply button to settings, rename Save button to OK, readme update.
1 parent 43256dc commit 2af689b

File tree

6 files changed

+28
-14
lines changed

6 files changed

+28
-14
lines changed

Readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ For older versions (prior to v0.12) please use JRE/JDK 8 (and JavaFX if you're N
2525

2626
### Running on Linux
2727

28-
Just start it as usual Java application:
28+
Just start it as regular Java application:
2929
```
3030
$ java -jar mplayer4anime.jar
3131
```

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<name>mplayer4anime</name>
99

1010
<artifactId>mplayer4anime</artifactId>
11-
<version>0.14-SNAPSHOT</version>
11+
<version>0.14.1-SNAPSHOT</version>
1212

1313
<packaging>jar</packaging>
1414

src/main/java/mplayer4anime/Settings/SettingsController.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,13 @@ private void Cancel(){
7777
}
7878

7979
@FXML
80-
private void Save(){
80+
private void Ok(){
81+
this.Apply();
8182
Stage thisStage = (Stage) pathToMplayerLbl.getScene().getWindow(); // TODO: consider refactoring. Non-urgent.
83+
thisStage.close();
84+
}
85+
@FXML
86+
private void Apply(){
8287
appPreferences.setPath(pathToMplayerLbl.getText());
8388
appPreferences.setSubtilesFirst(subtitlesFirstCheckBox.isSelected());
8489
appPreferences.setSubsExtensionsList(subExtensionListController.getList());
@@ -87,7 +92,5 @@ private void Save(){
8792
appPreferences.setAudioExtensionsList(audioExtensionListController.getList());
8893

8994
MediatorControl.getInstance().sentUpdates(); // TODO: implement list to track what should be updated
90-
91-
thisStage.close();
9295
}
9396
}

src/main/resources/Settings/SettingsLayout.fxml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,7 @@
4444
</Label>
4545
<HBox alignment="CENTER_LEFT" VBox.vgrow="NEVER">
4646
<children>
47-
<Label text="%settings_SubtitlesTabFirst" />
48-
<Pane HBox.hgrow="ALWAYS" />
49-
<CheckBox fx:id="subtitlesFirstCheckBox" mnemonicParsing="false" />
47+
<CheckBox fx:id="subtitlesFirstCheckBox" mnemonicParsing="false" text="%settings_SubtitlesTabFirst" />
5048
</children>
5149
</HBox>
5250
</children>
@@ -132,8 +130,19 @@
132130
<HBox prefWidth="200.0" spacing="5.0" VBox.vgrow="NEVER">
133131
<children>
134132
<Pane HBox.hgrow="ALWAYS" />
135-
<Button cancelButton="true" mnemonicParsing="false" onAction="#Cancel" text="%CancelBtn" />
136-
<Button mnemonicParsing="false" onAction="#Save" text="%SaveBtn" />
133+
<Button mnemonicParsing="false" onAction="#Ok" text="%OkBtn">
134+
<graphic>
135+
<SVGPath content="M21,7L9,19L3.5,13.5L4.91,12.09L9,16.17L19.59,5.59L21,7Z" />
136+
</graphic></Button>
137+
<Button mnemonicParsing="false" onAction="#Apply" text="%ApplyBtn">
138+
<graphic>
139+
<SVGPath content="M21,7L9,19L3.5,13.5L4.91,12.09L9,16.17L19.59,5.59L21,7Z" />
140+
</graphic>
141+
</Button>
142+
<Button cancelButton="true" mnemonicParsing="false" onAction="#Cancel" text="%CancelBtn">
143+
<graphic>
144+
<SVGPath content="M 8.705,8.59 A 6.705,6.705 0 0 1 15.41,15.295 6.705,6.705 0 0 1 8.705,22 6.705,6.705 0 0 1 2,15.295 6.705,6.705 0 0 1 8.705,8.59 m 0,1.341 a 5.364,5.364 0 0 0 -5.364,5.364 c 0,1.240425 0.422415,2.380275 1.12644,3.292155 L 11.997155,11.05744 C 11.085275,10.353415 9.945425,9.931 8.705,9.931 m 0,10.728 a 5.364,5.364 0 0 0 5.364,-5.364 c 0,-1.240425 -0.422415,-2.380275 -1.12644,-3.292155 L 5.412845,19.53256 C 6.324725,20.236585 7.464575,20.659 8.705,20.659 Z" />
145+
</graphic></Button>
137146
</children>
138147
<padding>
139148
<Insets bottom="5.0" left="5.0" right="5.0" top="5.0" />

src/main/resources/locale.properties

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
about_line1=mplayer4amine distributes under GNU GPLv3 license.
2-
about_line2=Release: v0.14
2+
about_line2=Release: v0.14.1
33
about_line3=Development & maintenance by Dmitry Isaenko.
44
about_AboutName=About
55
main_tab_audio=Audio
@@ -10,7 +10,7 @@ lbl_AudioPane=Audio
1010
lbl_VideoPane=Video
1111
lbl_SubsPane=Subtitles
1212
settings_PathToMplayerLbl=Path to mplayer executable:
13-
SaveBtn=Save
13+
OkBtn=OK
1414
settings_SettingsName=Settings
1515
main_tab_subtitles=Subtitles
1616
settings_SubtitlesTabFirst=Show 'Subutitles' tab first after application starts:
@@ -55,6 +55,7 @@ settings_Tab_Audio=Audio
5555
settings_Tab_Subtitles=Subtitles
5656
settings_videoExtensionList=Avaliable video files extensions:
5757
settings_audioExtensionList=Avaliable audio layer extensions:
58+
ApplyBtn=Apply
5859
5960
6061

src/main/resources/locale_rus.properties

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
menu_File_Recent=\u041F\u043E\u0441\u043B\u0435\u0434\u043D\u0438\u0435 \u0444\u0430\u0439\u043B\u044B...
22
about_line1=mplayer4amine \u0440\u0430\u0441\u043F\u0440\u043E\u0441\u0442\u0440\u0430\u043D\u044F\u0435\u0442\u0441\u044F \u043F\u043E \u043B\u0438\u0446\u0435\u043D\u0437\u0438\u0438 GNU GPLv3.
3-
about_line2=\u0420\u0435\u043B\u0438\u0437: v0.14
3+
about_line2=\u0420\u0435\u043B\u0438\u0437: v0.14.1
44
about_line3=\u0420\u0430\u0437\u0440\u0430\u0431\u043E\u0442\u0430\u043D\u043E \u0438 \u043F\u043E\u0434\u0434\u0435\u0440\u0436\u0438\u0432\u0430\u0435\u0442\u0441\u044F \u0414\u043C\u0438\u0442\u0440\u0438\u0435\u043C \u0418\u0441\u0430\u0435\u043D\u043A\u043E.
55
about_AboutName=\u041E \u043F\u0440\u0438\u043B\u043E\u0436\u0435\u043D\u0438\u0438
66
main_tab_audio=\u0410\u0443\u0434\u0438\u043E
@@ -11,7 +11,7 @@ lbl_AudioPane=\u0410\u0443\u0434\u0438\u043E
1111
lbl_VideoPane=\u0412\u0438\u0434\u0435\u043E
1212
lbl_SubsPane=\u0421\u0443\u0431\u0442\u0438\u0442\u0440\u044B
1313
settings_PathToMplayerLbl=\u0420\u0430\u0441\u043F\u043E\u043B\u043E\u0436\u0435\u043D\u0438\u0435 mplayer:
14-
SaveBtn=\u0421\u043E\u0445\u0440\u0430\u043D\u0438\u0442\u044C
14+
OkBtn=\u041E\u041A
1515
settings_SettingsName=\u041D\u0430\u0441\u0442\u0440\u043E\u0439\u043A\u0438
1616
main_tab_subtitles=\u0421\u0443\u0431\u0442\u0438\u0442\u0440\u044B
1717
settings_SubtitlesTabFirst=\u041F\u0440\u0438 \u0437\u0430\u043F\u0443\u0441\u043A\u0435 \u0441\u043F\u0435\u0440\u0432\u0430 \u043F\u043E\u043A\u0430\u0437\u044B\u0432\u0430\u0442\u044C \u0432\u043A\u043B\u0430\u0434\u043A\u0443 "\u0421\u0443\u0431\u0442\u0438\u0442\u0440\u044B":
@@ -55,4 +55,5 @@ settings_Tab_Subtitles=\u0421\u0443\u0431\u0442\u0438\u0442\u0440\u044B
5555
settings_Tab_Video=\u0412\u0438\u0434\u0435\u043E
5656
settings_videoExtensionList=\u0414\u043E\u0441\u0442\u0443\u043F\u043D\u044B\u0435 \u0440\u0430\u0441\u0448\u0438\u0440\u0435\u043D\u0438\u044F \u0434\u043B\u044F \u0444\u0430\u0439\u043B\u043E\u0432 \u0432\u0438\u0434\u0435\u043E:
5757
settings_audioExtensionList=\u0414\u043E\u0441\u0442\u0443\u043F\u043D\u044B\u0435 \u0440\u0430\u0441\u0448\u0438\u0440\u0435\u043D\u0438\u044F \u0434\u043B\u044F \u0430\u0443\u0434\u0438\u043E\u0434\u043E\u0440\u043E\u0436\u0435\u043A:
58+
ApplyBtn=\u041F\u0440\u0438\u043C\u0435\u043D\u0438\u0442\u044C
5859

0 commit comments

Comments
 (0)