Merge pull request #91 from developmentseed/IdAsStringOrNumber

allow Feature **id** to be either a String or a Number

Author: vincentsarago

CHANGELOG.md

@@ -39,6 +39,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Do not validates arbitrary dictionaries. Make `Type` a mandatory key for objects (https://github.com/developmentseed/geojson-pydantic/pull/94)
 - Add Geometry discriminator when parsing geometry objects (author @eseglem, https://github.com/developmentseed/geojson-pydantic/pull/101)
 - Mixed Dimensionality WKTs (make sure the coordinates are either all 2D or 3D) (author @eseglem, https://github.com/developmentseed/geojson-pydantic/pull/107)
+- allow Feature's **id** to be either a String or a Number
 
 ### Removed
 

geojson_pydantic/features.py

@@ -2,7 +2,7 @@
 
 from typing import Any, Dict, Generic, Iterator, List, Literal, Optional, TypeVar, Union
 
-from pydantic import BaseModel, Field, validator
+from pydantic import BaseModel, Field, StrictInt, StrictStr, validator
 from pydantic.generics import GenericModel
 
 from geojson_pydantic.geo_interface import GeoInterfaceMixin
@@ -19,7 +19,7 @@ class Feature(GenericModel, Generic[Geom, Props], GeoInterfaceMixin):
     type: Literal["Feature"]
     geometry: Union[Geom, None] = Field(...)
     properties: Union[Props, None] = Field(...)
-    id: Optional[str] = None
+    id: Optional[Union[StrictInt, StrictStr]] = None
     bbox: Optional[BBox] = None
 
     class Config:

tests/test_features.py

@@ -190,6 +190,20 @@ def test_feature_collection_geo_interface_with_null_geometry():
     assert "bbox" in fc.__geo_interface__["features"][1]
 
 
+@pytest.mark.parametrize("id", ["a", 1, "1"])
+def test_feature_id(id):
+    """Test if a string stays a string and if an int stays an int."""
+    feature = Feature(**test_feature, id=id)
+    assert feature.id == id
+
+
+@pytest.mark.parametrize("id", [True, 1.0])
+def test_bad_feature_id(id):
+    """make sure it raises error."""
+    with pytest.raises(ValidationError):
+        Feature(**test_feature, id=id)
+
+
 def test_feature_validation():
     """Test default."""
     assert Feature(type="Feature", properties=None, geometry=None)