Merge pull request #120 from developmentseed/bug/118-skip-bad-geometries

Skip invalid or empty geometries, close #118

Author: wronk

label_maker/label.py

@@ -10,6 +10,7 @@
 import mapbox_vector_tile
 import pyproj
 from shapely.geometry import shape, mapping, Polygon
+from shapely.errors import TopologicalError
 from rasterio.features import rasterize
 from geojson import Feature, FeatureCollection as fc
 from mercantile import tiles, feature, Tile
@@ -223,10 +224,15 @@ def _mapper(x, y, z, data, args):
                     if ff(feat):
                         feat['geometry']['coordinates'] = _convert_coordinates(feat['geometry']['coordinates'])
                         geo = shape(feat['geometry'])
-                        geo = geo.intersection(clip_mask)
+                        try:
+                            geo = geo.intersection(clip_mask)
+                        except TopologicalError as e:
+                            print(e, 'skipping')
+                            break
                         if cl.get('buffer'):
                             geo = geo.buffer(cl.get('buffer'), 4)
-                        geos.append((mapping(geo), i + 1))
+                        if not geo.is_empty:
+                            geos.append((mapping(geo), i + 1))
             result = rasterize(geos, out_shape=(256, 256))
             return ('{!s}-{!s}-{!s}'.format(x, y, z), result)
     return ('{!s}-{!s}-{!s}'.format(x, y, z), np.array())

test/integration/test_segmentation_labels.py

@@ -27,7 +27,7 @@ def test_cli(self):
         # our labels should look like this
         expected_sums = {
             '62092-50162-17': 0,
-            '62092-50163-17': 0,
+            '62092-50163-17': 2526,
             '62092-50164-17': 13500,
             '62093-50162-17': 36822,
             '62093-50164-17': 2400,

test/integration/test_segmentation_labels_sparse.py

@@ -26,6 +26,7 @@ def test_cli(self):
 
         # our labels should look like this
         expected_sums = {
+            '62092-50163-17': 2526,
             '62092-50164-17': 13500,
             '62093-50162-17': 36822,
             '62093-50164-17': 2400,