Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not use .browserslistrc when compiling Bootstrap 5 #19

Open
Jarek300 opened this issue May 6, 2021 · 2 comments
Open

Plugin does not use .browserslistrc when compiling Bootstrap 5 #19

Jarek300 opened this issue May 6, 2021 · 2 comments

Comments

@Jarek300
Copy link

Jarek300 commented May 6, 2021

'Visual Studio Code' and 'DartJS Sass Compiler and Sass Watcher' current versions.

I've downloaded Bootstrap 5 (from https://github.com/twbs/bootstrap/releases/download/v5.0.0/bootstrap-5.0.0-dist.zip), unzipped, opened directory bootstrap-5.0.0 and file scss\bootstrap.scss.

Bootstrap 5 sources contain .browserslistrc file.

The compiled bootstrap.css differs from official bootstrap.css. It contains all possible browser prefixes. For example:

.row {
  --bs-gutter-x: 1.5rem;
  --bs-gutter-y: 0;
  display: -webkit-box;
  display: -ms-flexbox;
  display: flex;
  -ms-flex-wrap: wrap;
      flex-wrap: wrap;
  margin-top: calc(var(--bs-gutter-y) * -1);
  margin-right: calc(var(--bs-gutter-x) / -2);
  margin-left: calc(var(--bs-gutter-x) / -2);
}

instead of

.row {
  --bs-gutter-x: 1.5rem;
  --bs-gutter-y: 0;
  display: flex;
  flex-wrap: wrap;
  margin-top: calc(var(--bs-gutter-y) * -1);
  margin-right: calc(var(--bs-gutter-x) / -2);
  margin-left: calc(var(--bs-gutter-x) / -2);
}

@lekoala
Copy link

lekoala commented Jun 1, 2021

yes it would be great to use .browserslistrc instead of ide settings!

in the meantime it's easy to add '>= 0.5% and last 2 major versions and not Explorer <= 11 and not dead' in the settings and choose this one as default

@akkumar
Copy link
Contributor

akkumar commented Jun 2, 2021

This seems like a very important feature.

I will look into this later over the weekend to see how the plugin automatically reads .browserlistrc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants