Skip to content

Commit 3d2a7bd

Browse files
fix M5 iPad Pro models (#480)
* fix m5 iPad Pro models * Add changelog entry for PR 480. --------- Co-authored-by: Zandor Smith <info@zsinfo.nl>
1 parent 6baf21a commit 3d2a7bd

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
- Fixed `ApplePencilSupport` OptionSet raw values so that `.firstGenerationUsbC` no longer incorrectly overlaps with `.firstGeneration` and `.secondGeneration`. ([#474](https://github.com/devicekit/DeviceKit/pull/474))
2626
- Fixed naming of iPad mini devices to match Apple's official naming (lowercase "mini"). ([#458](https://github.com/devicekit/DeviceKit/issues/458))
2727
- Exclude unhandled files (`Info.plist`, `Device.swift.gyb`) to suppress SPM warnings. ([#484](https://github.com/devicekit/DeviceKit/pull/484))
28+
- Fixed M5 iPad Pro device identifiers and added image URLs. ([#480](https://github.com/devicekit/DeviceKit/pull/480))
2829

2930
## Version 5.7.0
3031

Source/Device.generated.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -428,11 +428,11 @@ public enum Device {
428428
case iPadPro13M4
429429
/// Device is an [iPad Pro 11-inch (M5)](https://support.apple.com/en-us/125406)
430430
///
431-
/// ![Image]()
431+
/// ![Image](https://cdsassets.apple.com/content/services/pub/image?productid=301271&size=240x240)
432432
case iPadPro11M5
433433
/// Device is an [iPad Pro 13-inch (M5)](https://support.apple.com/en-us/125406)
434434
///
435-
/// ![Image]()
435+
/// ![Image](https://cdsassets.apple.com/content/services/pub/image?productid=301273&size=240x240)
436436
case iPadPro13M5
437437
/// Device is a [HomePod](https://support.apple.com/kb/SP773)
438438
///
@@ -720,8 +720,8 @@ public enum Device {
720720
case "iPad14,5", "iPad14,6": return iPadPro12Inch6
721721
case "iPad16,3", "iPad16,4": return iPadPro11M4
722722
case "iPad16,5", "iPad16,6": return iPadPro13M4
723-
case "iPad17,3", "iPad17,4": return iPadPro11M5
724-
case "iPad17,5", "iPad17,6": return iPadPro13M5
723+
case "iPad17,1", "iPad17,2": return iPadPro11M5
724+
case "iPad17,3", "iPad17,4": return iPadPro13M5
725725
case "AudioAccessory1,1": return homePod
726726
case "i386", "x86_64", "arm64": return simulator(mapToDevice(identifier: ProcessInfo().environment["SIMULATOR_MODEL_IDENTIFIER"] ?? "iOS"))
727727
default: return unknown(identifier)

Source/Device.swift.gyb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,8 @@ iPads = [
141141
Device("iPadPro12Inch6", "Device is an [iPad Pro 12.9-inch (6th generation)](https://support.apple.com/kb/SP883)", "https://support.apple.com/library/APPLE/APPLECARE_ALLGEOS/SP882/ipad-pro-4gen-mainimage_2x.png", ["iPad14,5", "iPad14,6"], 12.9, (512, 683), "iPad Pro (12.9-inch) (6th generation)", "iPad Pro (12.9-inch) (6th generation)", 264, False, False, True, False, False, True, False, False, True, False, 23, False, 13, True, "m2", True, True),
142142
Device("iPadPro11M4", "Device is an [iPad Pro 11-inch (M4)](https://support.apple.com/en-us/119892)", "https://cdsassets.apple.com/content/services/pub/image?productid=301031&size=240x240", ["iPad16,3", "iPad16,4"], 11.0, (605, 417), "iPad Pro (11-inch) (M4)", "iPad Pro (11-inch) (M4)", 264, False, False, True, False, False, True, False, False, True, False, 34, False, 1, True, "m4", True, True),
143143
Device("iPadPro13M4", "Device is an [iPad Pro 13-inch (M4)](https://support.apple.com/en-us/119891)", "https://cdsassets.apple.com/content/services/pub/image?productid=301033&size=240x240", ["iPad16,5", "iPad16,6"], 13.0, (4, 3), "iPad Pro (13-inch) (M4)", "iPad Pro (13-inch) (M4)", 264, False, False, True, False, False, True, False, False, True, False, 34, False, 1, True, "m4", True, True),
144-
Device("iPadPro11M5", "Device is an [iPad Pro 11-inch (M5)](https://support.apple.com/en-us/125406)", "", ["iPad17,3", "iPad17,4"], 11.0, (605, 417), "iPad Pro (11-inch) (M5)", "iPad Pro (11-inch) (M5)", 264, False, False, True, False, False, True, False, False, True, False, 234, False, 1, True, "m5", True, True),
145-
Device("iPadPro13M5", "Device is an [iPad Pro 13-inch (M5)](https://support.apple.com/en-us/125406)", "", ["iPad17,5", "iPad17,6"], 13.0, (4, 3), "iPad Pro (13-inch) (M5)", "iPad Pro (13-inch) (M5)", 264, False, False, True, False, False, True, False, False, True, False, 234, False, 1, True, "m5", True, True),
144+
Device("iPadPro11M5", "Device is an [iPad Pro 11-inch (M5)](https://support.apple.com/en-us/125406)", "https://cdsassets.apple.com/content/services/pub/image?productid=301271&size=240x240", ["iPad17,1", "iPad17,2"], 11.0, (605, 417), "iPad Pro (11-inch) (M5)", "iPad Pro (11-inch) (M5)", 264, False, False, True, False, False, True, False, False, True, False, 234, False, 1, True, "m5", True, True),
145+
Device("iPadPro13M5", "Device is an [iPad Pro 13-inch (M5)](https://support.apple.com/en-us/125406)", "https://cdsassets.apple.com/content/services/pub/image?productid=301273&size=240x240", ["iPad17,3", "iPad17,4"], 13.0, (4, 3), "iPad Pro (13-inch) (M5)", "iPad Pro (13-inch) (M5)", 264, False, False, True, False, False, True, False, False, True, False, 234, False, 1, True, "m5", True, True),
146146
]
147147

148148
homePods = [

0 commit comments

Comments
 (0)