Skip to content

Commit 43fedd8

Browse files
authored
Fix Danger plist warning being triggered on every PR (#489)
The warning "Plist changed, don't forget to localize your plist values" was being incorrectly shown on every PR, even when no plist file was modified. Fixed two bugs in the Dangerfile: 1. Inverted condition: Changed from `if !is_plist_change` to `if is_plist_change` so the warning only fires when a plist is actually modified 2. Wrong file path: Changed from checking `"ProjectName/Info.plist"` to `"Source/Info.plist"` to match the actual project structure
1 parent 92f1800 commit 43fedd8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Dangerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ if has_app_changes && !has_test_changes && git.lines_of_code > 10
3131
end
3232

3333
# Info.plist file shouldn't change often. Leave warning if it changes.
34-
is_plist_change = git.modified_files.sort == ["ProjectName/Info.plist"].sort
34+
is_plist_change = git.modified_files.include?("Source/Info.plist")
3535

36-
if !is_plist_change
36+
if is_plist_change
3737
warn "Plist changed, don't forget to localize your plist values"
3838
end
3939

0 commit comments

Comments
 (0)